darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 23:26:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

Filter 'get_service_callback_api_for_service' to only get status updates

Browse Source 
Also rename it to 'get_service_delivery_status_callback_api_for_service'
This commit is contained in:
Pea Tyczynska
2018-07-18 10:14:32 +01:00
parent e81c395ab1
commit 86978c225a
7 changed files with 21 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/app/dao/test_service_callback_api_dao.py
View File

@@ -8,7 +8,7 @@ from app.dao.service_callback_api_dao import (
save_service_callback_api,
reset_service_callback_api,
get_service_callback_api,
get_service_callback_api_for_service)
get_service_delivery_status_callback_api_for_service)
from app.models import ServiceCallbackApi
from tests.app.db import create_service_callback_api
@@ -118,9 +118,9 @@ def test_get_service_callback_api(sample_service):
assert callback_api.updated_at is None
def test_get_service_callback_api_for_service(sample_service):
def test_get_service_delivery_status_callback_api_for_service(sample_service):
service_callback_api = create_service_callback_api(service=sample_service)
result = get_service_callback_api_for_service(sample_service.id)
result = get_service_delivery_status_callback_api_for_service(sample_service.id)
assert result.id == service_callback_api.id
assert result.url == service_callback_api.url
assert result.bearer_token == service_callback_api.bearer_token

4
tests/app/db.py
View File

@@ -316,11 +316,13 @@ def create_service_callback_api(
service,
url="https://something.com",
bearer_token="some_super_secret",
callback_type="delivery_status"
):
service_callback_api = ServiceCallbackApi(service_id=service.id,
url=url,
bearer_token=bearer_token,
updated_by_id=service.users[0].id
updated_by_id=service.users[0].id,
callback_type=callback_type
)
save_service_callback_api(service_callback_api)
return service_callback_api