From 8524bdb4bf6d61803c8fe13c5f31b6ec27331e1f Mon Sep 17 00:00:00 2001 From: Leo Hemsted Date: Mon, 11 Nov 2019 15:27:15 +0000 Subject: [PATCH] clean up provider details rest test we don't actually care what order the providers are returned in, so no point making a flaky test that asserts the order. This is just seen by platform admin and we do processing of the list on the admin side anyway. --- tests/app/provider_details/test_rest.py | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/tests/app/provider_details/test_rest.py b/tests/app/provider_details/test_rest.py index b096d8daf..dd3a41ab7 100644 --- a/tests/app/provider_details/test_rest.py +++ b/tests/app/provider_details/test_rest.py @@ -8,19 +8,11 @@ from tests import create_authorization_header from tests.app.db import create_ft_billing -def test_get_provider_details_in_type_and_identifier_order(client, notify_db): - response = client.get( - '/provider-details', - headers=[create_authorization_header()] - ) - assert response.status_code == 200 - json_resp = json.loads(response.get_data(as_text=True))['provider_details'] - assert len(json_resp) == 4 +def test_get_provider_details_returns_all_providers(admin_request, db_session): + json_resp = admin_request.get('provider_details.get_providers')['provider_details'] - assert json_resp[0]['identifier'] == 'ses' - assert json_resp[1]['identifier'] == 'mmg' - assert json_resp[2]['identifier'] == 'firetext' - assert json_resp[3]['identifier'] == 'dvla' + assert len(json_resp) == 4 + assert {x['identifier'] for x in json_resp} == {'ses', 'firetext', 'mmg', 'dvla'} def test_get_provider_details_by_id(client, notify_db):