darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 18:01:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback remove print statements

Browse Source
This commit is contained in:
Kenneth Kehl
2023-05-26 12:43:00 -07:00
parent aee14ed609
commit 8504b5aff1
4 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/celery/research_mode_tasks.py
View File

@@ -65,7 +65,6 @@ def sns_callback(notification_id):
# This will only work if all notifications, including successful ones, are in the notifications table # This will only work if all notifications, including successful ones, are in the notifications table
# If we decide to delete successful notifications, we will have to get this from notifications history # If we decide to delete successful notifications, we will have to get this from notifications history
print(f"NOTIFICATION_ID {str(notification_id)} status {notification.status} dtime {notification.completed_at}")
return json.dumps({ return json.dumps({
"CID": str(notification_id), "CID": str(notification_id),
"status": notification.status, "status": notification.status,

1
tests/app/inbound_sms/test_rest.py
View File

@@ -76,7 +76,6 @@ def test_post_to_get_inbound_sms_filters_international_user_number(admin_request
)['data'] )['data']
assert len(sms) == 2 assert len(sms) == 2
print(f'sms is: {sms}')
assert sms[1]['id'] == str(one.id) assert sms[1]['id'] == str(one.id)
assert sms[1]['user_number'] == str(one.user_number) assert sms[1]['user_number'] == str(one.user_number)

1
tests/app/notifications/test_notifications_ses_callback.py
View File

@@ -86,7 +86,6 @@ def test_check_and_queue_callback_task(mocker, sample_notification):
# callback_api doesn't match by equality for some # callback_api doesn't match by equality for some
# reason, so we need to take this approach instead # reason, so we need to take this approach instead
print(f'mock_create.mock_calls is: {mock_create.mock_calls}')
mock_create_args = mock_create.mock_calls[0][1] mock_create_args = mock_create.mock_calls[0][1]
assert mock_create_args[0] == sample_notification assert mock_create_args[0] == sample_notification
assert mock_create_args[1].id == callback_api.id assert mock_create_args[1].id == callback_api.id

2
tests/app/service_invite/test_service_invite_rest.py
View File

@@ -129,7 +129,6 @@ def test_get_all_invited_users_by_service(client, notify_db_session, sample_serv
for i in range(0, 5): for i in range(0, 5):
email = 'invited_user_{}@service.gov.uk'.format(i) email = 'invited_user_{}@service.gov.uk'.format(i)
invited_user = create_invited_user(sample_service, to_email_address=email) invited_user = create_invited_user(sample_service, to_email_address=email)
print(f"INVITED USER = {invited_user.auth_type}")
invites.append(invited_user) invites.append(invited_user)
url = '/service/{}/invite'.format(sample_service.id) url = '/service/{}/invite'.format(sample_service.id)
@@ -144,7 +143,6 @@ def test_get_all_invited_users_by_service(client, notify_db_session, sample_serv
json_resp = json.loads(response.get_data(as_text=True)) json_resp = json.loads(response.get_data(as_text=True))
invite_from = sample_service.users[0] invite_from = sample_service.users[0]
print(f"INVITE FROM {json_resp['data']}")
for invite in json_resp['data']: for invite in json_resp['data']:
assert invite['service'] == str(sample_service.id) assert invite['service'] == str(sample_service.id)