darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-21 07:51:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

merge from main

Browse Source
This commit is contained in:
Kenneth Kehl
2024-01-16 11:21:54 -08:00
parent f9f1013f5b 40f8718a61
commit 848b62092a
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/celery/scheduled_tasks.py
View File

@@ -98,6 +98,8 @@ def expire_or_delete_invitations():
raise raise
# TODO THIS IS ACTUALLY DEPRECATED, WE ARE REMOVING PHONE NUMBERS FROM THE DB
# SO THERE WILL BE NO REASON TO KEEP TRACK OF THIS COUNT
@notify_celery.task(name="check-db-notification-fails") @notify_celery.task(name="check-db-notification-fails")
def check_db_notification_fails(): def check_db_notification_fails():
""" """
@@ -113,6 +115,8 @@ def check_db_notification_fails():
last_value = redis_store.get("LAST_DB_NOTIFICATION_COUNT") last_value = redis_store.get("LAST_DB_NOTIFICATION_COUNT")
if not last_value: if not last_value:
last_value = 0 last_value = 0
else:
last_value = int(last_value.decode("utf-8"))
failed_count = dao_get_failed_notification_count() failed_count = dao_get_failed_notification_count()
if failed_count > last_value: if failed_count > last_value:

8
tests/app/celery/test_scheduled_tasks.py
View File

@@ -72,6 +72,8 @@ def test_should_check_db_notification_fails_task_less_than_25_percent(
mock_dao = mocker.patch( mock_dao = mocker.patch(
"app.celery.scheduled_tasks.dao_get_failed_notification_count" "app.celery.scheduled_tasks.dao_get_failed_notification_count"
) )
mock_redis = mocker.patch("app.celery.scheduled_tasks.redis_store")
mock_redis.get.return_value = 0
mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use") mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use")
mock_dao.return_value = 10 mock_dao.return_value = 10
check_db_notification_fails() check_db_notification_fails()
@@ -88,13 +90,13 @@ def test_should_check_db_notification_fails_task_over_50_percent(
"app.celery.scheduled_tasks.dao_get_failed_notification_count" "app.celery.scheduled_tasks.dao_get_failed_notification_count"
) )
mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use") mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use")
mock_redis = mocker.patch("app.celery.scheduled_tasks.redis_store.get") mock_redis = mocker.patch("app.celery.scheduled_tasks.redis_store")
mock_dao.return_value = 5001 mock_dao.return_value = 5001
mock_redis.return_value = 0 mock_redis.get.return_value = "0".encode("utf-8")
check_db_notification_fails() check_db_notification_fails()
assert mock_provider.call_count == 1 assert mock_provider.call_count == 1
mock_redis.return_value = 5001 mock_redis.get.return_value = "5001".encode("utf-8")
check_db_notification_fails() check_db_notification_fails()
assert mock_provider.call_count == 1 assert mock_provider.call_count == 1