darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-05 02:41:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Review and update uses of PRNG

Browse Source
This commit is contained in:
Ryan Ahearn
2022-08-19 15:26:12 +00:00
parent 3c035531aa
commit 806e2ad2dc
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/__init__.py
View File

@@ -1,5 +1,5 @@
import os import os
import random import secrets
import string import string
import time import time
import uuid import uuid
@@ -353,7 +353,7 @@ def create_uuid():
def create_random_identifier(): def create_random_identifier():
return ''.join(random.choice(string.ascii_uppercase + string.digits) for _ in range(16)) return ''.join(secrets.choice(string.ascii_uppercase + string.digits) for _ in range(16))
def setup_sqlalchemy_events(app): def setup_sqlalchemy_events(app):

2
app/celery/research_mode_tasks.py
View File

@@ -124,7 +124,7 @@ def create_fake_letter_response_file(self, reference):
dvla_response_data = '{}|Sent|0|Sorted'.format(reference) dvla_response_data = '{}|Sent|0|Sorted'.format(reference)
# try and find a filename that hasn't been taken yet - from a random time within the last 30 seconds # try and find a filename that hasn't been taken yet - from a random time within the last 30 seconds
for i in sorted(range(30), key=lambda _: random.random()): for i in sorted(range(30), key=lambda _: random.random()): # nosec B311 - not security related
upload_file_name = 'NOTIFY-{}-RSP.TXT'.format((now - timedelta(seconds=i)).strftime('%Y%m%d%H%M%S')) upload_file_name = 'NOTIFY-{}-RSP.TXT'.format((now - timedelta(seconds=i)).strftime('%Y%m%d%H%M%S'))
if not file_exists(current_app.config['DVLA_RESPONSE_BUCKET_NAME'], upload_file_name): if not file_exists(current_app.config['DVLA_RESPONSE_BUCKET_NAME'], upload_file_name):
break break

2
app/delivery/send_to_providers.py
View File

@@ -188,7 +188,7 @@ def provider_to_use(notification_type, international=True):
chosen_provider = active_providers[0] chosen_provider = active_providers[0]
else: else:
weights = [p.priority for p in active_providers] weights = [p.priority for p in active_providers]
chosen_provider = random.choices(active_providers, weights=weights)[0] chosen_provider = random.choices(active_providers, weights=weights)[0] # nosec B311 - this is not security/cryptography related
return notification_provider_clients.get_client_by_name_and_type(chosen_provider.identifier, notification_type) return notification_provider_clients.get_client_by_name_and_type(chosen_provider.identifier, notification_type)