darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update test to check personalisation

Browse Source 
While the API still has a column and field for personalisation I think
it makes sense for it to consider the personalisation when serialising
the broadcast, so we should have a test for this.

This way the API still works as a coherent whole, and the admin app just
happens to be a client of the API which doesn’t implement the
personalisation feature.

If we want to remove personalisation from the API at another time we
should do it wholesale.
This commit is contained in:
Chris Hill-Scott
2020-10-07 10:52:31 +01:00
parent 7da0d46767
commit 80352bafe1
1 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/broadcast_message/test_rest.py
View File

@@ -10,11 +10,21 @@ from tests.app.db import create_broadcast_message, create_template, create_servi
def test_get_broadcast_message(admin_request, sample_broadcast_service):
t = create_template(sample_broadcast_service, BROADCAST_TYPE)
bm = create_broadcast_message(t, areas={
"areas": ['place A', 'region B'],
"simple_polygons": [[[50.1, 1.2], [50.12, 1.2], [50.13, 1.2]]]
})
t = create_template(
sample_broadcast_service,
BROADCAST_TYPE,
content='This is a ((thing))'
)
bm = create_broadcast_message(
t,
areas={
"areas": ['place A', 'region B'],
"simple_polygons": [[[50.1, 1.2], [50.12, 1.2], [50.13, 1.2]]],
},
personalisation={
'thing': 'test',
},
)
response = admin_request.get(
'broadcast_message.get_broadcast_message',
@@ -25,13 +35,13 @@ def test_get_broadcast_message(admin_request, sample_broadcast_service):
assert response['id'] == str(bm.id)
assert response['template_id'] == str(t.id)
assert response['template_content'] == t.content
assert response['template_content'] == 'This is a test'
assert response['template_name'] == t.name
assert response['status'] == BroadcastStatusType.DRAFT
assert response['created_at'] is not None
assert response['starts_at'] is None
assert response['areas'] == ['place A', 'region B']
assert response['personalisation'] == {}
assert response['personalisation'] == {'thing': 'test'}
def test_get_broadcast_message_404s_if_message_doesnt_exist(admin_request, sample_broadcast_service):