darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update the new endpoint to return a 404 if the job or service id are not found.

Browse Source 
All our endpoint should perform a check that the params are valid - this is an easy whay to check that and is standard for our endpoints.
I reverted the query to just filter by job id.
This commit is contained in:
Rebecca Law
2019-10-03 14:58:49 +01:00
parent c48aa77dd5
commit 7fc7d99dac
4 changed files with 26 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/app/job/test_rest.py
View File

@@ -563,15 +563,28 @@ def test_get_all_notifications_for_job_returns_correct_format(
assert resp['notifications'][0]['status'] == sample_notification_with_job.status
def test_get_notification_count_for_job_id(admin_request, mocker):
def test_get_notification_count_for_job_id(admin_request, mocker, sample_job):
mock_dao = mocker.patch('app.job.rest.dao_get_notification_count_for_job_id', return_value=3)
job_id = uuid.uuid4()
service_id = uuid.uuid4()
response = admin_request.get('job.get_notification_count_for_job_id', service_id=service_id, job_id=job_id)
mock_dao.assert_called_once_with(service_id=service_id, job_id=str(job_id))
response = admin_request.get('job.get_notification_count_for_job_id',
service_id=sample_job.service_id, job_id=sample_job.id)
mock_dao.assert_called_once_with(job_id=str(sample_job.id))
assert response["count"] == 3
def test_get_notification_count_for_job_id_for_wrong_service_id(admin_request, sample_job):
service_id = uuid.uuid4()
response = admin_request.get('job.get_notification_count_for_job_id', service_id=service_id,
job_id=sample_job.id, _expected_status=404)
assert response['message'] == 'No result found'
def test_get_notification_count_for_job_id_for_wrong_job_id(admin_request, sample_service):
job_id = uuid.uuid4()
response = admin_request.get('job.get_notification_count_for_job_id', service_id=sample_service.id,
job_id=job_id, _expected_status=404)
assert response['message'] == 'No result found'
def test_get_job_by_id(admin_request, sample_job):
job_id = str(sample_job.id)
service_id = sample_job.service.id