darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 18:01:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update the new endpoint to return a 404 if the job or service id are not found.

Browse Source 
All our endpoint should perform a check that the params are valid - this is an easy whay to check that and is standard for our endpoints.
I reverted the query to just filter by job id.
This commit is contained in:
Rebecca Law
2019-10-03 14:58:49 +01:00
parent c48aa77dd5
commit 7fc7d99dac
4 changed files with 26 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -555,7 +555,7 @@ def test_get_all_notifications_for_job_by_status(sample_job):
assert len(notifications(filter_dict={'status': NOTIFICATION_STATUS_TYPES[:3]}).items) == 3
def test_dao_get_notification_count_for_job_id(notify_db_session, notify_db):
def test_dao_get_notification_count_for_job_id(notify_db_session):
service = create_service()
template = create_template(service)
job = create_job(template, notification_count=3)
@@ -564,27 +564,16 @@ def test_dao_get_notification_count_for_job_id(notify_db_session, notify_db):
create_notification(template)
assert dao_get_notification_count_for_job_id(service_id=service.id, job_id=job.id) == 3
assert dao_get_notification_count_for_job_id(job_id=job.id) == 3
def test_dao_get_notification_count_for_job_id_only_finds_notification_already_in_db(notify_db_session, notify_db):
def test_dao_get_notification_count_for_job_id_returns_zero_for_no_notifications_for_job(notify_db_session):
service = create_service()
template = create_template(service)
job = create_job(template, notification_count=3)
create_notification(template)
assert dao_get_notification_count_for_job_id(service_id=service.id, job_id=job.id) == 0
def test_dao_get_notification_count_for_job_id_doesnt_work_with_non_existing_service_id(notify_db_session, notify_db):
service = create_service()
template = create_template(service)
job = create_job(template, notification_count=3)
for i in range(3):
create_notification(job=job)
fake_service_id = str(uuid.uuid4())
assert dao_get_notification_count_for_job_id(service_id=fake_service_id, job_id=job.id) == 0
assert dao_get_notification_count_for_job_id(job_id=job.id) == 0
def test_update_notification_sets_status(sample_notification):