darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Rename function to make it consistent

Browse Source 
This is consistent with the new "on_date" function. It was going
off the edge of my screen before in some parts of the code.
This commit is contained in:
Ben Thorner
2022-01-24 15:54:37 +00:00
parent 1213463b8e
commit 7f4b140f97
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/celery/nightly_tasks.py
View File

@@ -22,7 +22,7 @@ from app.dao.jobs_dao import (
from app.dao.notifications_dao import ( from app.dao.notifications_dao import (
dao_get_notifications_processing_time_stats, dao_get_notifications_processing_time_stats,
dao_timeout_notifications, dao_timeout_notifications,
get_service_ids_that_have_notifications_from_before_timestamp, get_service_ids_with_notifications_before,
move_notifications_to_notification_history, move_notifications_to_notification_history,
) )
from app.dao.service_data_retention_dao import ( from app.dao.service_data_retention_dao import (
@@ -107,7 +107,7 @@ def _delete_notifications_older_than_retention_by_type(notification_type):
# get a list of all service ids that we'll need to delete for. Typically that might only be 5% of services. # get a list of all service ids that we'll need to delete for. Typically that might only be 5% of services.
# This query takes a couple of mins to run. # This query takes a couple of mins to run.
service_ids_that_have_sent_notifications_recently = get_service_ids_that_have_notifications_from_before_timestamp( service_ids_that_have_sent_notifications_recently = get_service_ids_with_notifications_before(
notification_type, notification_type,
seven_days_ago seven_days_ago
) )

2
app/dao/notifications_dao.py
View File

@@ -784,7 +784,7 @@ def _duplicate_update_warning(notification, status):
) )
def get_service_ids_that_have_notifications_from_before_timestamp(notification_type, timestamp): def get_service_ids_with_notifications_before(notification_type, timestamp):
return { return {
row.service_id row.service_id
for row in db.session.query( for row in db.session.query(