darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 13:38:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix test

Browse Source
This commit is contained in:
Kenneth Kehl
2025-08-22 10:39:35 -07:00
parent fb8fed288d
commit 7f38ceeb03
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/job/test_rest.py
View File

@@ -533,12 +533,17 @@ def test_get_recent_notifications_for_job_in_reverse_order_of_job_number(
@pytest.mark.parametrize( @pytest.mark.parametrize(
"expected_notification_count, status_args", "expected_notification_count, status_args, expected_phones, expected_personalisation",
[ [
(1, [NotificationStatus.CREATED]), (1, [NotificationStatus.CREATED], {0: "15555555555"}, {0: ""}),
(0, [NotificationStatus.SENDING]), (0, [NotificationStatus.SENDING], {}, {}),
(1, [NotificationStatus.CREATED, NotificationStatus.SENDING]), (
(0, [NotificationStatus.SENDING, NotificationStatus.DELIVERED]), 1,
[NotificationStatus.CREATED, NotificationStatus.SENDING],
{0: "15555555555"},
{0: ""},
),
(0, [NotificationStatus.SENDING, NotificationStatus.DELIVERED], {}, {}),
], ],
) )
def test_get_all_notifications_for_job_filtered_by_status( def test_get_all_notifications_for_job_filtered_by_status(
@@ -546,15 +551,17 @@ def test_get_all_notifications_for_job_filtered_by_status(
sample_job, sample_job,
expected_notification_count, expected_notification_count,
status_args, status_args,
expected_phones,
expected_personalisation,
mocker, mocker,
): ):
mock_job = mocker.patch("app.job.rest.get_job_from_s3") mock_job = mocker.patch("app.job.rest.get_job_from_s3")
mock_job.return_value = None mock_job.return_value = None
mock_s3 = mocker.patch("app.job.rest.extract_phones") mock_s3 = mocker.patch("app.job.rest.extract_phones")
mock_s3.return_value = {0: "15555555555"} mock_s3.return_value = expected_phones
mock_s3_personalisation = mocker.patch("app.job.rest.extract_personalisation") mock_s3_personalisation = mocker.patch("app.job.rest.extract_personalisation")
mock_s3_personalisation.return_value = {0: ""} mock_s3_personalisation.return_value = expected_personalisation
sample_job.job_row_number = 0 sample_job.job_row_number = 0
create_notification(job=sample_job, to_field="1", status=NotificationStatus.CREATED) create_notification(job=sample_job, to_field="1", status=NotificationStatus.CREATED)