darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-09 06:53:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Kenneth Kehl
2025-10-06 09:37:16 -07:00
parent 30bad7dd70
commit 7e1228190b
1 changed files with 29 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/app/delivery/test_send_to_providers.py
View File

@@ -393,9 +393,15 @@ def test_should_send_sms_with_downgraded_content(notify_db_session, mocker):
db_notification.personalisation = {"misc": placeholder} db_notification.personalisation = {"misc": placeholder}
db_notification.reply_to_text = "testing" db_notification.reply_to_text = "testing"
mock_client = MagicMock() mock_boto_client = mocker.patch("boto3.client")
mock_client.send_sms.return_value = "reference" mock_sns = MagicMock()
send_mock = mocker.patch("app.aws_sns_client", mock_client) mock_boto_client.return_value = mock_sns
mock_sns.send_sms.return_value = "reference"
mock_sns.name = "sns"
mocker.patch(
"app.delivery.send_to_providers.provider_to_use",
return_value=mock_sns,
)
mock_phone = mocker.patch("app.delivery.send_to_providers.get_phone_number_from_s3") mock_phone = mocker.patch("app.delivery.send_to_providers.get_phone_number_from_s3")
mock_phone.return_value = "15555555555" mock_phone.return_value = "15555555555"
@@ -407,7 +413,7 @@ def test_should_send_sms_with_downgraded_content(notify_db_session, mocker):
send_to_providers.send_sms_to_provider(db_notification) send_to_providers.send_sms_to_provider(db_notification)
send_mock.send_sms.assert_called_once_with( mock_sns.send_sms.assert_called_once_with(
to=ANY, content=gsm_message, reference=ANY, sender=ANY, international=False to=ANY, content=gsm_message, reference=ANY, sender=ANY, international=False
) )
@@ -418,9 +424,15 @@ def test_send_sms_should_use_service_sms_sender(
mocker.patch("app.delivery.send_to_providers.redis_store", return_value=None) mocker.patch("app.delivery.send_to_providers.redis_store", return_value=None)
mock_client = MagicMock() mock_boto_client = mocker.patch("boto3.client")
mock_client.send_sms.return_value = "reference" mock_sns = MagicMock()
send_mock = mocker.patch("app.aws_sns_client", mock_client) mock_boto_client.return_value = mock_sns
mock_sns.send_sms.return_value = "reference"
mock_sns.name = "sns"
mocker.patch(
"app.delivery.send_to_providers.provider_to_use",
return_value=mock_sns,
)
mocker.patch("app.delivery.send_to_providers.update_notification_message_id") mocker.patch("app.delivery.send_to_providers.update_notification_message_id")
sms_sender = create_service_sms_sender( sms_sender = create_service_sms_sender(
@@ -442,7 +454,7 @@ def test_send_sms_should_use_service_sms_sender(
db_notification, db_notification,
) )
send_mock.send_sms.assert_called_once_with( mock_sns.send_sms.assert_called_once_with(
to=ANY, to=ANY,
content=ANY, content=ANY,
reference=ANY, reference=ANY,
@@ -717,9 +729,15 @@ def test_should_update_billable_units_and_status_according_to_research_mode_and_
return_value=None, return_value=None,
) )
mock_client = MagicMock() mock_boto_client = mocker.patch("boto3.client")
mock_client.send_sms.return_value = "reference" mock_sns = MagicMock()
mocker.patch("app.aws_sns_client", mock_client) mock_boto_client.return_value = mock_sns
mock_sns.send_sms.return_value = "reference"
mock_sns.name = "sns"
mocker.patch(
"app.delivery.send_to_providers.provider_to_use",
return_value=mock_sns,
)
mocker.patch( mocker.patch(
"app.delivery.send_to_providers.send_sms_response", "app.delivery.send_to_providers.send_sms_response",
side_effect=__update_notification(notification, research_mode, expected_status), side_effect=__update_notification(notification, research_mode, expected_status),