darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Normalize outbound SMS sender number in notifications API

Browse Source 
Some of the tests don't set up a service sms_sender, so we need to
check if it's None before trying to format the number.
This commit is contained in:
Alexey Bezhan
2017-12-18 16:17:20 +00:00
parent d5b6bd85fe
commit 7df9fdf42a
2 changed files with 63 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/v2/notifications/post_notifications.py
View File

@@ -2,6 +2,8 @@ import functools
from flask import request, jsonify, current_app, abort
from notifications_utils.recipients import try_validate_and_format_phone_number
from app import api_user, authenticated_service
from app.config import QueueNames
from app.models import (
@@ -208,9 +210,13 @@ def get_reply_to_text(notification_type, form, template):
elif notification_type == SMS_TYPE:
service_sms_sender_id = form.get("sms_sender_id", None)
reply_to = check_service_sms_sender_id(
sms_sender_id = check_service_sms_sender_id(
str(authenticated_service.id), service_sms_sender_id, notification_type
) or template.get_reply_to_text()
)
if sms_sender_id:
reply_to = try_validate_and_format_phone_number(sms_sender_id)
else:
reply_to = template.get_reply_to_text()
elif notification_type == LETTER_TYPE:
reply_to = template.get_reply_to_text()