darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 06:21:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

The free sms allowances are changing for the financial year starting

Browse Source 
April 1 2021.

In this PR there is a command to set annual_billing for all active
services with the the new defaults.

The new method `set_default_free_allowance_for_service` will also be
called in a PR to follow that will set a services free allowance to the
default if the organisation for the service is changed.
This commit is contained in:
Rebecca Law
2021-03-25 08:10:22 +00:00
parent 47c2ced614
commit 7da5abc17b
4 changed files with 178 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
tests/app/dao/test_annual_billing_dao.py
View File

@@ -1,11 +1,15 @@
import pytest
from freezegun import freeze_time
from app.dao.annual_billing_dao import (
dao_create_or_update_annual_billing_for_year,
dao_get_free_sms_fragment_limit_for_year,
dao_update_annual_billing_for_future_years,
set_default_free_allowance_for_service,
)
from app.dao.date_util import get_current_financial_year_start_year
from tests.app.db import create_annual_billing
from app.models import AnnualBilling
from tests.app.db import create_annual_billing, create_service_with_organisation
def test_dao_update_free_sms_fragment_limit(notify_db_session, sample_service):
@@ -40,3 +44,48 @@ def test_dao_update_annual_billing_for_future_years(notify_db_session, sample_se
assert dao_get_free_sms_fragment_limit_for_year(sample_service.id, current_year) is None
assert dao_get_free_sms_fragment_limit_for_year(sample_service.id, current_year + 1).free_sms_fragment_limit == 9999
assert dao_get_free_sms_fragment_limit_for_year(sample_service.id, current_year + 2).free_sms_fragment_limit == 9999
@pytest.mark.parametrize('org_type, year, expected_default',
[('central', 2021, 150000),
('local', 2021, 25000),
('nhs_central', 2021, 150000),
('nhs_local', 2021, 25000),
('nhs_gp', 2021, 10000),
('emergency_service', 2021, 25000),
('school_or_college', 2021, 10000),
('other', 2021, 10000),
(None, 2021, 10000),
('central', 2020, 250000),
('local', 2020, 25000),
('nhs_central', 2020, 250000),
('nhs_local', 2020, 25000),
('nhs_gp', 2020, 25000),
('emergency_service', 2020, 25000),
('school_or_college', 2020, 25000),
('other', 2020, 25000),
(None, 2020, 25000),
])
def test_set_default_free_allowance_for_service(notify_db_session, org_type, year, expected_default):
service = create_service_with_organisation(org_type=org_type)
set_default_free_allowance_for_service(service=service, year_start=year)
annual_billing = AnnualBilling.query.all()
assert len(annual_billing) == 1
assert annual_billing[0].service_id == service.id
assert annual_billing[0].free_sms_fragment_limit == expected_default
@freeze_time('2021-03-29 14:02:00')
def test_set_default_free_allowance_for_service_using_correct_year(sample_service, mocker):
mock_dao = mocker.patch('app.dao.annual_billing_dao.dao_create_or_update_annual_billing_for_year')
set_default_free_allowance_for_service(service=sample_service, year_start=None)
mock_dao.assert_called_once_with(
sample_service.id,
25000,
2020
)

8
tests/app/db.py
View File

@@ -199,6 +199,14 @@ def create_service_with_defined_sms_sender(
return service
def create_service_with_organisation(org_type):
service = create_service(service_name=f'{org_type} service')
org = create_organisation(name=f'{org_type} org', organisation_type=org_type)
dao_add_service_to_organisation(service=service, organisation_id=org.id)
return service
def create_template(
service,
template_type=SMS_TYPE,