mirror of
https://github.com/GSA/notifications-api.git
synced 2026-02-02 17:31:14 -05:00
code review feedback
This commit is contained in:
@@ -1,4 +1,6 @@
|
|||||||
|
import csv
|
||||||
import datetime
|
import datetime
|
||||||
|
from io import StringIO
|
||||||
import re
|
import re
|
||||||
import time
|
import time
|
||||||
from concurrent.futures import ThreadPoolExecutor
|
from concurrent.futures import ThreadPoolExecutor
|
||||||
@@ -395,21 +397,19 @@ def get_job_from_s3(service_id, job_id):
|
|||||||
|
|
||||||
|
|
||||||
def extract_phones(job):
|
def extract_phones(job):
|
||||||
job = job.split("\r\n")
|
job_csv_data = StringIO(job)
|
||||||
first_row = job[0]
|
csv_reader = csv.reader(job_csv_data)
|
||||||
job.pop(0)
|
first_row = next(csv_reader)
|
||||||
first_row = first_row.split(",")
|
|
||||||
phone_index = 0
|
phone_index = 0
|
||||||
for item in first_row:
|
for i, item in enumerate(first_row):
|
||||||
# Note: may contain a BOM and look like \ufeffphone number
|
|
||||||
if item.lower().lstrip("\ufeff") == "phone number":
|
if item.lower().lstrip("\ufeff") == "phone number":
|
||||||
|
phone_index = i
|
||||||
break
|
break
|
||||||
phone_index = phone_index + 1
|
|
||||||
|
|
||||||
phones = {}
|
phones = {}
|
||||||
job_row = 0
|
job_row = 0
|
||||||
for row in job:
|
for row in csv_reader:
|
||||||
row = row.split(",")
|
|
||||||
|
|
||||||
if phone_index >= len(row):
|
if phone_index >= len(row):
|
||||||
phones[job_row] = "Unavailable"
|
phones[job_row] = "Unavailable"
|
||||||
|
|||||||
Reference in New Issue
Block a user