darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 23:55:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

raise 404 when unknown url

Browse Source 
consistent with other endpoints.

also refactor of notification_schema to separate some fns to a different file
This commit is contained in:
Leo Hemsted
2017-07-20 15:23:46 +01:00
parent 9caf45451e
commit 79e33073c9
5 changed files with 55 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/v2/notifications/post_notifications.py
View File

@@ -1,6 +1,6 @@
import functools
from flask import request, jsonify, current_app
from flask import request, jsonify, current_app, abort
from app import api_user, authenticated_service
from app.config import QueueNames
@@ -18,12 +18,13 @@ from app.notifications.validators import (
validate_template
)
from app.schema_validation import validate
from app.v2.errors import BadRequestError
from app.v2.notifications import v2_notification_blueprint
from app.v2.notifications.notification_schemas import (
post_sms_request,
post_email_request,
post_letter_request,
post_letter_request
)
from app.v2.notifications.create_response import (
create_post_sms_response_from_notification,
create_post_email_response_from_notification,
create_post_letter_response_from_notification
@@ -39,7 +40,7 @@ def post_notification(notification_type):
elif notification_type == LETTER_TYPE:
form = validate(request.get_json(), post_letter_request)
else:
raise BadRequestError(message='Unknown notification type {}'.format(notification_type))
abort(404)
check_service_has_permission(notification_type, authenticated_service.permissions)