darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-19 09:01:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

* Updated imports to comply with pep8 for better maintainability

Browse Source 
* Removed extra log messages so there are not two log messages being
generated per exception, as InvalidRequest also logs, updated the
InvalidRequest log message to include the exception type and exception
information
* Added extra asserts to ensure the exception messages are printed
This commit is contained in:
Richard Chapman
2018-03-12 11:05:05 +00:00
parent 04048aa220
commit 79a6ce8782
2 changed files with 27 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/app/template/test_rest.py
View File

@@ -946,7 +946,7 @@ def test_preview_letter_template_precompiled_s3_error(
'GetObject'
))
admin_request.get(
request = admin_request.get(
'template.preview_letter_template_by_notification_id',
service_id=notification.service_id,
notification_id=notification.id,
@@ -954,6 +954,10 @@ def test_preview_letter_template_precompiled_s3_error(
_expected_status=500
)
assert request['message'] == "Error extracting requested page from PDF file for notification_id {} type " \
"<class 'botocore.exceptions.ClientError'> An error occurred (403) " \
"when calling the GetObject operation: Unauthorized".format(notification.id)
def test_preview_letter_template_precompiled_png_file_type(
notify_api,
@@ -1128,7 +1132,8 @@ def test_preview_letter_template_precompiled_png_template_preview_pdf_error(
mocker.patch('app.template.rest.get_letter_pdf', return_value=pdf_content)
mocker.patch('app.template.rest.extract_page_from_pdf', side_effect=PdfReadError())
error_message = "PDF Error message"
mocker.patch('app.template.rest.extract_page_from_pdf', side_effect=PdfReadError(error_message))
request_mock.post(
'http://localhost/notifications-template-preview/precompiled-preview.png',
@@ -1137,10 +1142,13 @@ def test_preview_letter_template_precompiled_png_template_preview_pdf_error(
status_code=404
)
admin_request.get(
request = admin_request.get(
'template.preview_letter_template_by_notification_id',
service_id=notification.service_id,
notification_id=notification.id,
file_type='png',
_expected_status=500
)
assert request['message'] == "Error extracting requested page from PDF file for notification_id {} type " \
"{} {}".format(notification.id, type(PdfReadError()), error_message)