mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-20 23:41:17 -05:00
fix case sensitivity looking up phone number
This commit is contained in:
@@ -101,12 +101,8 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
|
|||||||
# At the same time we don't want to store it in redis or the db
|
# At the same time we don't want to store it in redis or the db
|
||||||
# So this is a little recycling mechanism to reduce the number of downloads.
|
# So this is a little recycling mechanism to reduce the number of downloads.
|
||||||
job = JOBS.get(job_id)
|
job = JOBS.get(job_id)
|
||||||
# TODO REMOVE
|
|
||||||
current_app.logger.info(f"HERE IS THE JOB FROM CACHE {job}")
|
|
||||||
if job is None:
|
if job is None:
|
||||||
job = get_job_from_s3(service_id, job_id)
|
job = get_job_from_s3(service_id, job_id)
|
||||||
# TODO REMOVE
|
|
||||||
current_app.logger.info(f"HERE IS THE JOB FROM S3 {job}")
|
|
||||||
JOBS[job_id] = job
|
JOBS[job_id] = job
|
||||||
incr_jobs_cache_misses()
|
incr_jobs_cache_misses()
|
||||||
else:
|
else:
|
||||||
@@ -118,16 +114,12 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
|
|||||||
first_row = first_row.split(",")
|
first_row = first_row.split(",")
|
||||||
phone_index = 0
|
phone_index = 0
|
||||||
for item in first_row:
|
for item in first_row:
|
||||||
if item == "phone number":
|
if item.lower() == "phone number":
|
||||||
break
|
break
|
||||||
phone_index = phone_index + 1
|
phone_index = phone_index + 1
|
||||||
|
|
||||||
correct_row = job[job_row_number]
|
correct_row = job[job_row_number]
|
||||||
correct_row = correct_row.split(",")
|
correct_row = correct_row.split(",")
|
||||||
# TODO REMOVE
|
|
||||||
current_app.logger.info(
|
|
||||||
f"HERE IS THE CORRECT ROW AND PHONE INDEX {correct_row} {phone_index}"
|
|
||||||
)
|
|
||||||
|
|
||||||
# This could happen if an old job cannot be retrieved from s3
|
# This could happen if an old job cannot be retrieved from s3
|
||||||
if len(correct_row) <= phone_index:
|
if len(correct_row) <= phone_index:
|
||||||
|
|||||||
@@ -61,6 +61,12 @@ def test_get_s3_file_makes_correct_call(notify_api, mocker):
|
|||||||
0,
|
0,
|
||||||
"15551111111",
|
"15551111111",
|
||||||
),
|
),
|
||||||
|
(
|
||||||
|
"Phone number,name,date,time,address,English,Spanish\r\n15553333333,Tim,10/16,2:00 PM,5678 Tom St.,no,yes",
|
||||||
|
"ddd",
|
||||||
|
0,
|
||||||
|
"15553333333",
|
||||||
|
),
|
||||||
],
|
],
|
||||||
)
|
)
|
||||||
def test_get_phone_number_from_s3(
|
def test_get_phone_number_from_s3(
|
||||||
|
|||||||
Reference in New Issue
Block a user