darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 23:55:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Kenneth Kehl
2023-05-04 08:15:08 -07:00
parent 3fb113a83e
commit 7892c52d11
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/clients/cloudwatch/aws_cloudwatch.py
View File

@@ -59,7 +59,7 @@ class AwsCloudwatchClient(CloudwatchClient):
return all_log_events return all_log_events
def check_sms(self, message_id, notification_id): def check_sms(self, message_id, notification_id):
# TODO presumably there is a better way to get the account number # TODO presumably there is a better way to get the aws account number
account_number = os.getenv("SES_DOMAIN_ARN") account_number = os.getenv("SES_DOMAIN_ARN")
account_number = account_number.replace('arn:aws:ses:us-west-2:', '') account_number = account_number.replace('arn:aws:ses:us-west-2:', '')
account_number = account_number.split(":") account_number = account_number.split(":")

8
tests/app/clients/test_aws_cloudwatch.py
View File

@@ -6,6 +6,10 @@ from app import aws_cloudwatch_client
def test_check_sms_no_event_error_condition(notify_api, mocker): def test_check_sms_no_event_error_condition(notify_api, mocker):
boto_mock = mocker.patch.object(aws_cloudwatch_client, '_client', create=True) boto_mock = mocker.patch.object(aws_cloudwatch_client, '_client', create=True)
# TODO
# we do this to get the AWS account number, and it seems like unit tests locally have
# access to the env variables but when we push the PR they do not. Is there a better way to get it?
mocker.patch.dict('os.environ', {"SES_DOMAIN_ARN": "1111:"})
message_id = 'aaa' message_id = 'aaa'
notification_id = 'bbb' notification_id = 'bbb'
boto_mock.filter_log_events.return_value = [] boto_mock.filter_log_events.return_value = []
@@ -49,6 +53,8 @@ def test_check_sms_success(notify_api, mocker):
aws_cloudwatch_client.init_app(current_app) aws_cloudwatch_client.init_app(current_app)
boto_mock = mocker.patch.object(aws_cloudwatch_client, '_client', create=True) boto_mock = mocker.patch.object(aws_cloudwatch_client, '_client', create=True)
boto_mock.filter_log_events.side_effect = side_effect boto_mock.filter_log_events.side_effect = side_effect
mocker.patch.dict('os.environ', {"SES_DOMAIN_ARN": "1111:"})
message_id = 'succeed' message_id = 'succeed'
notification_id = 'ccc' notification_id = 'ccc'
with notify_api.app_context(): with notify_api.app_context():
@@ -66,6 +72,8 @@ def test_check_sms_failure(notify_api, mocker):
aws_cloudwatch_client.init_app(current_app) aws_cloudwatch_client.init_app(current_app)
boto_mock = mocker.patch.object(aws_cloudwatch_client, '_client', create=True) boto_mock = mocker.patch.object(aws_cloudwatch_client, '_client', create=True)
boto_mock.filter_log_events.side_effect = side_effect boto_mock.filter_log_events.side_effect = side_effect
mocker.patch.dict('os.environ', {"SES_DOMAIN_ARN": "1111:"})
message_id = 'fail' message_id = 'fail'
notification_id = 'bbb' notification_id = 'bbb'
with notify_api.app_context(): with notify_api.app_context():