darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 14:08:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename variable, it's a better name now.

Browse Source
This commit is contained in:
Rebecca Law
2021-02-17 13:15:29 +00:00
parent e77534fb17
commit 77b76ea0a4
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/config.py
View File

@@ -179,7 +179,7 @@ class Config(object):
MOU_SIGNED_ON_BEHALF_SIGNER_RECEIPT_TEMPLATE_ID = 'c20206d5-bf03-4002-9a90-37d5032d9e84' MOU_SIGNED_ON_BEHALF_SIGNER_RECEIPT_TEMPLATE_ID = 'c20206d5-bf03-4002-9a90-37d5032d9e84'
MOU_SIGNED_ON_BEHALF_ON_BEHALF_RECEIPT_TEMPLATE_ID = '522b6657-5ca5-4368-a294-6b527703bd0b' MOU_SIGNED_ON_BEHALF_ON_BEHALF_RECEIPT_TEMPLATE_ID = '522b6657-5ca5-4368-a294-6b527703bd0b'
MOU_NOTIFY_TEAM_ALERT_TEMPLATE_ID = 'd0e66c4c-0c50-43f0-94f5-f85b613202d4' MOU_NOTIFY_TEAM_ALERT_TEMPLATE_ID = 'd0e66c4c-0c50-43f0-94f5-f85b613202d4'
NOTIFY_NUMBER_SMS_SENDER = '07984404008' NOTIFY_INTERNATIONAL_SMS_SENDER = '07984404008'
BROKER_URL = 'sqs://' BROKER_URL = 'sqs://'
BROKER_TRANSPORT_OPTIONS = { BROKER_TRANSPORT_OPTIONS = {

4
app/user/rest.py
View File

@@ -108,7 +108,7 @@ def update_user_attribute(user_id):
if is_uk_phone_number(recipient): if is_uk_phone_number(recipient):
reply_to = template.service.get_default_sms_sender() reply_to = template.service.get_default_sms_sender()
else: else:
reply_to = current_app.config['NOTIFY_NUMBER_SMS_SENDER'] reply_to = current_app.config['NOTIFY_INTERNATIONAL_SMS_SENDER']
else: else:
return jsonify(data=user_to_update.serialize()), 200 return jsonify(data=user_to_update.serialize()), 200
service = Service.query.get(current_app.config['NOTIFY_SERVICE_ID']) service = Service.query.get(current_app.config['NOTIFY_SERVICE_ID'])
@@ -274,7 +274,7 @@ def create_2fa_code(template_id, user_to_send_to, secret_code, recipient, person
if is_uk_phone_number(recipient): if is_uk_phone_number(recipient):
reply_to = template.service.get_default_sms_sender() reply_to = template.service.get_default_sms_sender()
else: else:
reply_to = current_app.config['NOTIFY_NUMBER_SMS_SENDER'] reply_to = current_app.config['NOTIFY_INTERNATIONAL_SMS_SENDER']
elif template.template_type == EMAIL_TYPE: elif template.template_type == EMAIL_TYPE:
reply_to = template.service.get_default_reply_to_email_address() reply_to = template.service.get_default_reply_to_email_address()
saved_notification = persist_notification( saved_notification = persist_notification(

2
migrations/versions/0346_notify_number_sms_sender.py
View File

@@ -15,7 +15,7 @@ down_revision = '0345_move_broadcast_provider'
SMS_SENDER_ID = 'd24b830b-57b4-4f14-bd80-02f46f8d54de' SMS_SENDER_ID = 'd24b830b-57b4-4f14-bd80-02f46f8d54de'
NOTIFY_SERVICE_ID = current_app.config['NOTIFY_SERVICE_ID'] NOTIFY_SERVICE_ID = current_app.config['NOTIFY_SERVICE_ID']
INBOUND_NUMBER = current_app.config['NOTIFY_NUMBER_SMS_SENDER'] INBOUND_NUMBER = current_app.config['NOTIFY_INTERNATIONAL_SMS_SENDER']
def upgrade(): def upgrade():

2
tests/app/user/test_rest.py
View File

@@ -329,7 +329,7 @@ def test_post_user_attribute_with_updated_by_sends_notification_to_international
assert resp.status_code == 200, resp.get_data(as_text=True) assert resp.status_code == 200, resp.get_data(as_text=True)
notification = Notification.query.first() notification = Notification.query.first()
assert notification.reply_to_text == current_app.config['NOTIFY_NUMBER_SMS_SENDER'] assert notification.reply_to_text == current_app.config['NOTIFY_INTERNATIONAL_SMS_SENDER']
def test_archive_user(mocker, client, sample_user): def test_archive_user(mocker, client, sample_user):

2
tests/app/user/test_rest_verify.py
View File

@@ -494,4 +494,4 @@ def test_send_user_2fa_code_sends_from_number_for_international_numbers(
assert resp.status_code == 204 assert resp.status_code == 204
notification = Notification.query.first() notification = Notification.query.first()
assert notification.reply_to_text == current_app.config['NOTIFY_NUMBER_SMS_SENDER'] assert notification.reply_to_text == current_app.config['NOTIFY_INTERNATIONAL_SMS_SENDER']