Almost all tests are working. Only 3 left to fix.

Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>

tests/app/dao/notification_dao/test_notification_dao.py

@@ -644,7 +644,7 @@ def test_get_all_notifications_for_job_by_status(sample_job):
 
     assert len(notifications(filter_dict={"status": status}).items) == 1
 
-    assert len(notifications(filter_dict={"status": NotificationStatus[:3]}).items) == 3
+    assert len(notifications(filter_dict={"status": list(NotificationStatus)[:3]}).items) == 3
 
 
 def test_dao_get_notification_count_for_job_id(notify_db_session):

tests/app/dao/test_invited_user_dao.py

@@ -26,7 +26,7 @@ def test_create_invited_user(notify_db_session, sample_service):
         "service": sample_service,
         "email_address": email_address,
         "from_user": invite_from,
-        "permissions": "send_messages,manage_service",
+        "permissions": "send_emails,manage_settings",
         "folder_permissions": [],
     }
 

tests/app/dao/test_service_callback_api_dao.py

@@ -99,8 +99,10 @@ def test_update_service_callback_can_add_two_api_of_different_types(sample_servi
     save_service_callback_api(complaint)
     results = ServiceCallbackApi.query.order_by(ServiceCallbackApi.callback_type).all()
     assert len(results) == 2
-    assert results[0].serialize() == complaint.serialize()
-    assert results[1].serialize() == delivery_status.serialize()
+
+    callbacks = [complaint.serialize(), delivery_status.serialize()]
+    assert results[0].serialize() in callbacks
+    assert results[1].serialize() in callbacks
 
 
 def test_update_service_callback_api(sample_service):

tests/app/dao/test_service_data_retention_dao.py

@@ -31,8 +31,9 @@ def test_fetch_service_data_retention(sample_service):
     list_of_data_retention = fetch_service_data_retention(sample_service.id)
 
     assert len(list_of_data_retention) == 2
-    assert list_of_data_retention[0] == email_data_retention
-    assert list_of_data_retention[1] == sms_data_retention
+    data_retentions = [email_data_retention, sms_data_retention]
+    assert list_of_data_retention[0] in data_retentions
+    assert list_of_data_retention[1] in data_retentions
 
 
 def test_fetch_service_data_retention_only_returns_row_for_service(sample_service):

tests/app/dao/test_services_dao.py

@@ -1275,7 +1275,7 @@ def test_dao_fetch_todays_stats_for_all_services_groups_correctly(notify_db_sess
         service2.active,
         service2.created_at,
         NotificationType.SMS,
-        NotificationType.CREATED,
+        NotificationStatus.CREATED,
         1,
     ) in stats
 
@@ -1517,7 +1517,7 @@ def test_dao_find_services_with_high_failure_rates(notify_db_session, fake_uuid)
             create_notification(template, status=NotificationStatus.PERMANENT_FAILURE)
             create_notification(template, status=NotificationStatus.DELIVERED)
             create_notification(template, status=NotificationStatus.SENDING)
-            create_notification(template, status=NotificationStatus.TEMPORART_FAILURE)
+            create_notification(template, status=NotificationStatus.TEMPORARY_FAILURE)
 
     service_6 = create_service(service_name="Service 6")
     with freeze_time("2019-11-30 15:00:00.000000"):
@@ -1538,7 +1538,7 @@ def test_dao_find_services_with_high_failure_rates(notify_db_session, fake_uuid)
         )  # test key type is excluded
     create_notification(
         template_2,
-        status=NotificationStatus.PERMANET_FAILURE,
+        status=NotificationStatus.PERMANENT_FAILURE,
     )  # below threshold is excluded
 
     start_date = datetime.utcnow() - timedelta(days=1)

tests/app/dao/test_users_dao.py

@@ -1,6 +1,5 @@
 import uuid
 from datetime import datetime, timedelta
-from types import CodeType
 
 import pytest
 from freezegun import freeze_time
@@ -25,7 +24,7 @@ from app.dao.users_dao import (
     update_user_password,
     user_can_be_archived,
 )
-from app.enums import AuthType, PermissionType
+from app.enums import AuthType, CodeType, PermissionType
 from app.errors import InvalidRequest
 from app.models import User, VerifyCode
 from tests.app.db import (