darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-11 15:52:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update reviewee to author

Browse Source 
This changeset adjusts the language slightly to use clearer terms for the individuals involved in a code review.
This commit is contained in:
Carlo Costino
2024-02-13 16:27:55 -05:00
committed by GitHub
parent 2f5fea6d81
commit 755f5e085e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/all.md
View File

@@ -38,7 +38,7 @@
- [System Description](#system-description) - [System Description](#system-description)
- [Code Reviews](#code-reviews) - [Code Reviews](#code-reviews)
- [For the reviewer](#for-the-reviewer) - [For the reviewer](#for-the-reviewer)
- [For the reviewee](#for-the-reviewee) - [For the author](#for-the-author)
- [Run Book](#run-book) - [Run Book](#run-book)
- [Alerts, Notifications, Monitoring](#-alerts-notifications-monitoring) - [Alerts, Notifications, Monitoring](#-alerts-notifications-monitoring)
- [Restaging Apps](#-restaging-apps) - [Restaging Apps](#-restaging-apps)
@@ -771,7 +771,7 @@ community.
Given this basis of approaching code reviews, here are some general guidelines Given this basis of approaching code reviews, here are some general guidelines
and suggestions for how to approach a code review from the perspectives of both and suggestions for how to approach a code review from the perspectives of both
the reviewer and the reviewee. the reviewer and the author.
### For the reviewer ### For the reviewer
@@ -814,7 +814,7 @@ several concerns about the overall approach, it will likely be helpful to
schedule time to speak with the author(s) directly and talk through everything. schedule time to speak with the author(s) directly and talk through everything.
This can save folks a lot of misunderstanding and back-and-forth! This can save folks a lot of misunderstanding and back-and-forth!
### For the reviewee ### For the author
When receiving a code review, please remember that someone took the time to look When receiving a code review, please remember that someone took the time to look
over all of your work with a critical eye to make sure our standards are being over all of your work with a critical eye to make sure our standards are being