Add tests for autoconfirmation

app/notifications/notifications_ses_callback.py

@@ -36,6 +36,9 @@ def process_ses_response():
             current_app.logger.info("SNS subscription confirmation url: {}".format(ses_request['SubscribeURL']))
             subscribed_topic = confirm_subscription(ses_request)
             current_app.logger.info("Automatically subscribed to topic: {}".format(subscribed_topic))
+            return jsonify(
+                result="success", message="SES callback succeeded"
+            ), 200
 
         errors = validate_callback_data(data=ses_request, fields=['Message'], client_name=client_name)
         if errors:

app/notifications/utils.py

@@ -4,5 +4,5 @@ import requests
 def confirm_subscription(confirmation_request):
     url = confirmation_request['SubscribeURL']
     response = requests.get(url)
-    if response.code < 400:
-        return confirmation_request['TopicArn']
+    response.raise_for_status()
+    return confirmation_request['TopicArn']