darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

cleanup

Browse Source
This commit is contained in:
Kenneth Kehl
2023-11-07 07:08:42 -08:00
parent aa7b5d3905
commit 7392663b10
2 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/commands.py
View File

@@ -835,13 +835,9 @@ def create_new_service(name, message_limit, restricted, email_from, created_by_i
@notify_command(name="promote-user-to-platform-admin") @notify_command(name="promote-user-to-platform-admin")
@click.option("-u", "--user-email-address", required=True, prompt=True) @click.option("-u", "--user-email-address", required=True, prompt=True)
def promote_user_to_platform_admin(user_email_address): def promote_user_to_platform_admin(user_email_address):
print("enter") # If the email address is wrong, sqlalchemy will automatically raise a NoResultFound error which is what we want.
# See tests.
user = get_user_by_email(user_email_address) user = get_user_by_email(user_email_address)
print(f"user is {user}")
# if not user:
# raise ValueError(f"could not find user for {user_email_address}")
print("ok to proceed")
user.platform_admin = True user.platform_admin = True
db.session.add(user) db.session.add(user)
db.session.commit() db.session.commit()
print("finished")

3
tests/app/test_commands.py
View File

@@ -405,14 +405,13 @@ def test_promote_user_to_platform_admin(
assert sample_user.platform_admin is False assert sample_user.platform_admin is False
assert sample_platform_admin.platform_admin is True assert sample_platform_admin.platform_admin is True
result = notify_api.test_cli_runner().invoke( notify_api.test_cli_runner().invoke(
promote_user_to_platform_admin, promote_user_to_platform_admin,
[ [
"-u", "-u",
"notify@digital.fake.gov", "notify@digital.fake.gov",
], ],
) )
print(result)
user = get_user_by_email("notify@digital.fake.gov") user = get_user_by_email("notify@digital.fake.gov")
assert user.platform_admin is True assert user.platform_admin is True