darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-02 17:48:36 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update to strip down DAO and clarify tests

Browse Source
This commit is contained in:
Ken Tsang
2017-05-16 12:33:27 +01:00
parent 54d801979c
commit 733c16b2bb
4 changed files with 23 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
tests/app/dao/test_service_permissions_dao.py
View File

@@ -5,51 +5,37 @@ from app.dao.service_permissions_dao import (
from app.models import (
EMAIL_TYPE, SMS_TYPE, LETTER_TYPE, INTERNATIONAL_SMS_TYPE, INCOMING_SMS_TYPE, SERVICE_PERMISSION_TYPES)
from tests.app.db import create_service_permission, create_service
from tests.app.db import create_service_permission
def test_create_service_permission(sample_service):
service_permission_type = SMS_TYPE
service_permission = create_service_permission(
service_id=sample_service.id, permission=service_permission_type)
service_id=sample_service.id, permission=SMS_TYPE)
assert len(service_permission) == 1
assert all(sp.service_id == sample_service.id for sp in service_permission)
assert all(sp.permission in service_permission_type for sp in service_permission)
assert service_permission[0].service_id == sample_service.id
assert service_permission[0].permission == SMS_TYPE
def test_fetch_service_permissions_gets_service_permissions(sample_service):
service_permission_types = [LETTER_TYPE, EMAIL_TYPE, SMS_TYPE]
for spt in service_permission_types:
create_service_permission(service_id=sample_service.id, permission=spt)
create_service_permission(service_id=sample_service.id, permission=LETTER_TYPE)
create_service_permission(service_id=sample_service.id, permission=INTERNATIONAL_SMS_TYPE)
create_service_permission(service_id=sample_service.id, permission=SMS_TYPE)
service_permissions = dao_fetch_service_permissions(sample_service.id)
assert len(service_permissions) == len(service_permission_types)
assert len(service_permissions) == 3
assert all(sp.service_id == sample_service.id for sp in service_permissions)
assert all(sp.permission in service_permission_types for sp in service_permissions)
def test_create_invalid_service_permissions_raises_error(sample_service):
service_permission_type = 'invalid'
with pytest.raises(ValueError) as e:
create_service_permission(service_id=sample_service.id, permission=service_permission_type)
assert "'invalid' not of service permission type: {}".format(str(SERVICE_PERMISSION_TYPES)) in str(e.value)
assert all(sp.permission in [LETTER_TYPE, INTERNATIONAL_SMS_TYPE, SMS_TYPE] for sp in service_permissions)
def test_remove_service_permission(sample_service):
service_permission_types_to_create = [EMAIL_TYPE, INCOMING_SMS_TYPE]
service_permission_type_to_remove = EMAIL_TYPE
service_permission_type_remaining = INCOMING_SMS_TYPE
create_service_permission(service_id=sample_service.id, permission=EMAIL_TYPE)
create_service_permission(service_id=sample_service.id, permission=INCOMING_SMS_TYPE)
for spt in service_permission_types_to_create:
create_service_permission(service_id=sample_service.id, permission=spt)
dao_remove_service_permission(sample_service.id, service_permission_type_to_remove)
dao_remove_service_permission(sample_service.id, EMAIL_TYPE)
permissions = dao_fetch_service_permissions(sample_service.id)
assert len(permissions) == 1
assert permissions[0].permission == service_permission_type_remaining
assert permissions[0].permission == INCOMING_SMS_TYPE
assert permissions[0].service_id == sample_service.id