darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1202 from alphagov/v1-send-letter-error-msg

Browse Source 
Added a proper error response if the notification type is not supported.
This commit is contained in:
Rebecca Law
2017-08-24 16:31:21 +01:00
committed by GitHub
parent aeb817614f d4422dd35f
commit 717c0510a3
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/app/notifications/rest/test_send_notification.py
View File

@@ -1205,3 +1205,17 @@ def test_should_not_allow_notification_if_service_permission_not_set(
assert error_json['result'] == 'error'
assert error_json['message']['service'][0] == expected_error
@pytest.mark.parametrize(
"notification_type, err_msg",
[("letter", "letter notification type is not supported, please use the latest version of the client"),
("apple", "apple notification type is not supported")])
def test_should_throw_exception_if_notification_type_is_invalid(client, sample_service, notification_type, err_msg):
auth_header = create_authorization_header(service_id=sample_service.id)
response = client.post(
path='/notifications/{}'.format(notification_type),
data={},
headers=[('Content-Type', 'application/json'), auth_header])
assert response.status_code == 400
assert json.loads(response.get_data(as_text=True))["message"] == err_msg