darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-26 17:23:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

get rid of skips

Browse Source
This commit is contained in:
Kenneth Kehl
2025-08-29 08:59:52 -07:00
parent 6dd5e320c9
commit 70367dc1e4
3 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.ds.baseline
View File

@@ -285,7 +285,7 @@
"filename": "tests/app/notifications/test_validators.py", "filename": "tests/app/notifications/test_validators.py",
"hashed_secret": "6c1a8443963d02d13ffe575a71abe19ea731fb66", "hashed_secret": "6c1a8443963d02d13ffe575a71abe19ea731fb66",
"is_verified": false, "is_verified": false,
"line_number": 670, "line_number": 668,
"is_secret": false "is_secret": false
} }
], ],
@@ -374,5 +374,5 @@
} }
] ]
}, },
"generated_at": "2025-08-29T15:48:27Z" "generated_at": "2025-08-29T15:59:40Z"
} }

2
tests/app/notifications/test_validators.py
View File

@@ -473,7 +473,6 @@ def test_validate_template_calls_all_validators_exception_message_too_long(
@pytest.mark.parametrize("key_type", [KeyType.TEST, KeyType.NORMAL]) @pytest.mark.parametrize("key_type", [KeyType.TEST, KeyType.NORMAL])
# @pytest.mark.skip("We currently don't support international numbers")
def test_validate_and_format_recipient_fails_when_international_number_and_service_does_not_allow_int_sms( def test_validate_and_format_recipient_fails_when_international_number_and_service_does_not_allow_int_sms(
key_type, key_type,
notify_db_session, notify_db_session,
@@ -493,7 +492,6 @@ def test_validate_and_format_recipient_fails_when_international_number_and_servi
@pytest.mark.parametrize("key_type", [KeyType.TEST, KeyType.NORMAL]) @pytest.mark.parametrize("key_type", [KeyType.TEST, KeyType.NORMAL])
# @pytest.mark.skip("We currently don't support international numbers")
def test_validate_and_format_recipient_succeeds_with_international_numbers_if_service_does_allow_int_sms( def test_validate_and_format_recipient_succeeds_with_international_numbers_if_service_does_allow_int_sms(
key_type, sample_service_full_permissions key_type, sample_service_full_permissions
): ):

3
tests/app/organization/test_rest.py
View File

@@ -194,7 +194,6 @@ def _get_organizations():
@pytest.mark.parametrize("org_type", ["nhs_central", "nhs_local", "nhs_gp"]) @pytest.mark.parametrize("org_type", ["nhs_central", "nhs_local", "nhs_gp"])
@pytest.mark.skip(reason="Update for TTS")
def test_post_create_organization_sets_default_nhs_branding_for_nhs_orgs( def test_post_create_organization_sets_default_nhs_branding_for_nhs_orgs(
admin_request, notify_db_session, nhs_email_branding, org_type admin_request, notify_db_session, nhs_email_branding, org_type
): ):
@@ -374,7 +373,6 @@ def test_update_other_organization_attributes_doesnt_clear_domains(
@pytest.mark.parametrize("new_org_type", ["nhs_central", "nhs_local", "nhs_gp"]) @pytest.mark.parametrize("new_org_type", ["nhs_central", "nhs_local", "nhs_gp"])
@pytest.mark.skip(reason="Update for TTS")
def test_post_update_organization_to_nhs_type_updates_branding_if_none_present( def test_post_update_organization_to_nhs_type_updates_branding_if_none_present(
admin_request, nhs_email_branding, notify_db_session, new_org_type admin_request, nhs_email_branding, notify_db_session, new_org_type
): ):
@@ -401,7 +399,6 @@ def test_post_update_organization_to_nhs_type_updates_branding_if_none_present(
@pytest.mark.parametrize("new_org_type", ["nhs_central", "nhs_local", "nhs_gp"]) @pytest.mark.parametrize("new_org_type", ["nhs_central", "nhs_local", "nhs_gp"])
@pytest.mark.skip(reason="Update for TTS")
def test_post_update_organization_to_nhs_type_does_not_update_branding_if_default_branding_set( def test_post_update_organization_to_nhs_type_does_not_update_branding_if_default_branding_set(
admin_request, nhs_email_branding, notify_db_session, new_org_type admin_request, nhs_email_branding, notify_db_session, new_org_type
): ):