From 6fd92c493146b77268575eea52baf0f97b25f745 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 5 Mar 2020 14:31:51 +0000 Subject: [PATCH] Test for letters not returned recently MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If you have some returned letters, but none in the last 7 days, we don’t count how many you have in the last 7 days. But we should test to make sure we’re not going to the database again. --- tests/app/service/test_rest.py | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tests/app/service/test_rest.py b/tests/app/service/test_rest.py index 4c3ee2b78..423c5c1a5 100644 --- a/tests/app/service/test_rest.py +++ b/tests/app/service/test_rest.py @@ -3396,6 +3396,30 @@ def test_get_returned_letter_statistics(admin_request, sample_service): } +@freeze_time('2019-12-11 13:30') +def test_get_returned_letter_statistics_with_old_returned_letters( + mocker, + admin_request, + sample_service, +): + create_returned_letter(sample_service, reported_at=datetime.utcnow() - timedelta(days=8)) + create_returned_letter(sample_service, reported_at=datetime.utcnow() - timedelta(days=800)) + + count_mock = mocker.patch( + 'app.service.rest.fetch_recent_returned_letter_count', + ) + + assert admin_request.get( + 'service.returned_letter_statistics', + service_id=sample_service.id, + ) == { + 'returned_letter_count': 0, + 'most_recent_report': '2019-12-03 00:00:00.000000', + } + + assert count_mock.called is False + + def test_get_returned_letter_statistics_with_no_returned_letters( mocker, admin_request,