darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 23:41:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Added logging to show the entire form posted to us by the SMS client providers.

Browse Source 
This can be useful information when debugging what happened to a notificaiton.
Recently there was a discrepancy between the failure type used by each provider for a particular number, this logging would have helped.
This commit is contained in:
Rebecca Law
2017-07-12 14:19:39 +01:00
parent eb8cf26c80
commit 6fb4e16067
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/notifications/notifications_sms_callback.py
View File

@@ -1,4 +1,5 @@
from flask import Blueprint from flask import Blueprint
from flask import current_app
from flask import json from flask import json
from flask import request, jsonify from flask import request, jsonify
@@ -22,6 +23,10 @@ def process_mmg_response():
success, errors = process_sms_client_response(status=str(data.get('status')), success, errors = process_sms_client_response(status=str(data.get('status')),
reference=data.get('CID'), reference=data.get('CID'),
client_name=client_name) client_name=client_name)
current_app.logger.info(
"Full delivery response from {} for notification: {}\n{}".format(client_name, request.form.get('reference'),
request.form))
if errors: if errors:
raise InvalidRequest(errors, status_code=400) raise InvalidRequest(errors, status_code=400)
else: else:
@@ -38,6 +43,9 @@ def process_firetext_response():
raise InvalidRequest(errors, status_code=400) raise InvalidRequest(errors, status_code=400)
status = request.form.get('status') status = request.form.get('status')
current_app.logger.info(
"Full delivery response from {} for notification: {}\n{}".format(client_name, request.form.get('reference'),
request.form))
success, errors = process_sms_client_response(status=status, success, errors = process_sms_client_response(status=status,
reference=request.form.get('reference'), reference=request.form.get('reference'),
client_name=client_name) client_name=client_name)