darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 06:21:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

notify-34 fix skipped tests

Browse Source
This commit is contained in:
Kenneth Kehl
2023-05-18 09:46:36 -07:00
parent 49a73a2238
commit 6e597aafad
7 changed files with 7 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/dao/test_fact_billing_dao.py
View File

@@ -211,8 +211,6 @@ def test_fetch_billing_data_for_day_returns_empty_list(notify_db_session):
assert results == []
# TODO: ready for reactivation?
@pytest.mark.skip(reason="Needs updating for TTS: Timezone handling")
def test_fetch_billing_data_for_day_uses_correct_table(notify_db_session):
service = create_service()
create_service_data_retention(service, notification_type='email', days_of_retention=3)

2
tests/app/dao/test_jobs_dao.py
View File

@@ -116,7 +116,7 @@ def test_get_jobs_for_service(sample_template):
assert one_job_from_db != other_job_from_db
@pytest.mark.skip(reason="Needs updating for TTS: Timezone handling")
# @pytest.mark.skip(reason="Needs updating for TTS: Timezone handling")
def test_get_jobs_for_service_with_limit_days_param(sample_template):
one_job = create_job(sample_template)
old_job = create_job(sample_template, created_at=datetime.now() - timedelta(days=8))

4
tests/app/dao/test_services_dao.py
View File

@@ -871,7 +871,6 @@ def test_dao_fetch_todays_stats_for_service_only_includes_during_utc(notify_db_s
assert not stats.get('permanent-failure')
@pytest.mark.skip(reason="Needs updating for TTS: Timezone handling")
def test_dao_fetch_todays_stats_for_all_services_includes_all_services(notify_db_session):
# two services, each with an email and sms notification
service1 = create_service(service_name='service 1', email_from='service.1')
@@ -910,7 +909,6 @@ def test_dao_fetch_todays_stats_for_all_services_only_includes_today(notify_db_s
assert stats['failed'] == 1
@pytest.mark.skip(reason="Needs updating for TTS: Timezone handling")
def test_dao_fetch_todays_stats_for_all_services_groups_correctly(notify_db_session):
service1 = create_service(service_name='service 1', email_from='service.1')
service2 = create_service(service_name='service 2', email_from='service.2')
@@ -937,7 +935,6 @@ def test_dao_fetch_todays_stats_for_all_services_groups_correctly(notify_db_sess
service2.created_at, 'sms', 'created', 1) in stats
@pytest.mark.skip(reason="Needs updating for TTS: Timezone handling")
def test_dao_fetch_todays_stats_for_all_services_includes_all_keys_by_default(notify_db_session):
template = create_template(service=create_service())
create_notification(template=template, key_type=KEY_TYPE_NORMAL)
@@ -950,7 +947,6 @@ def test_dao_fetch_todays_stats_for_all_services_includes_all_keys_by_default(no
assert stats[0].count == 3
@pytest.mark.skip(reason="Needs updating for TTS: Timezone handling")
def test_dao_fetch_todays_stats_for_all_services_can_exclude_from_test_key(notify_db_session):
template = create_template(service=create_service())
create_notification(template=template, key_type=KEY_TYPE_NORMAL)