darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

add command to backfill template usage

Browse Source 
The command takes a service id and a day, grabs the historical data for
that day (potentially out of notification_history), and pops it in
redis (for eight days, same as if it were written to manually).

also, prefix template usage key with "service" to make clear that it's
a service id, and not an individual template id.
This commit is contained in:
Leo Hemsted
2018-04-03 15:55:22 +01:00
parent 8e73961f65
commit 6e554188bd
3 changed files with 48 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/app/notifications/test_process_notification.py
View File

@@ -226,7 +226,7 @@ def test_persist_notification_doesnt_touch_cache_for_old_keys_that_dont_exist(sa
)
mock_incr.assert_not_called()
mock_incr_hash_value.assert_called_once_with(
str(sample_template.service_id) + "-template-usage-2016-01-01",
"service-{}-template-usage-2016-01-01".format(sample_template.service_id),
sample_template.id
)
@@ -252,8 +252,8 @@ def test_persist_notification_increments_cache_if_key_exists(sample_template, sa
mock_incr.assert_called_once_with(str(sample_template.service_id) + "-2016-01-01-count", )
assert mock_incr_hash_value.mock_calls == [
call(str(sample_template.service_id) + "-template-counter-limit-7-days", sample_template.id),
call(str(sample_template.service_id) + "-template-usage-2016-01-01", sample_template.id),
call("{}-template-counter-limit-7-days".format(sample_template.service_id), sample_template.id),
call("service-{}-template-usage-2016-01-01".format(sample_template.service_id), sample_template.id),
]
@@ -493,10 +493,10 @@ def test_persist_notification_increments_and_expires_redis_template_usage(
key_type=sample_api_key.key_type,
)
mock_incr_hash_value.assert_called_once_with(
'{}-template-usage-{}'.format(str(sample_template.service_id), day_in_key),
'service-{}-template-usage-{}'.format(str(sample_template.service_id), day_in_key),
sample_template.id
)
mock_expire.assert_called_once_with(
'{}-template-usage-{}'.format(str(sample_template.service_id), day_in_key),
'service-{}-template-usage-{}'.format(str(sample_template.service_id), day_in_key),
current_app.config['EXPIRE_CACHE_EIGHT_DAYS']
)