fix or remove skipped tests

This commit is contained in:
Kenneth Kehl
2025-08-29 08:48:43 -07:00
parent 0490b44fcd
commit 6dd5e320c9
5 changed files with 5 additions and 11 deletions

View File

@@ -285,7 +285,7 @@
"filename": "tests/app/notifications/test_validators.py",
"hashed_secret": "6c1a8443963d02d13ffe575a71abe19ea731fb66",
"is_verified": false,
"line_number": 672,
"line_number": 670,
"is_secret": false
}
],
@@ -339,7 +339,7 @@
"filename": "tests/app/user/test_rest.py",
"hashed_secret": "0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33",
"is_verified": false,
"line_number": 874,
"line_number": 873,
"is_secret": false
}
],
@@ -374,5 +374,5 @@
}
]
},
"generated_at": "2025-08-12T18:08:49Z"
"generated_at": "2025-08-29T15:48:27Z"
}

View File

@@ -473,9 +473,7 @@ def test_validate_template_calls_all_validators_exception_message_too_long(
@pytest.mark.parametrize("key_type", [KeyType.TEST, KeyType.NORMAL])
@pytest.mark.skip(
"We currently don't support international numbers, our validation fails before here"
)
# @pytest.mark.skip("We currently don't support international numbers")
def test_validate_and_format_recipient_fails_when_international_number_and_service_does_not_allow_int_sms(
key_type,
notify_db_session,
@@ -495,7 +493,7 @@ def test_validate_and_format_recipient_fails_when_international_number_and_servi
@pytest.mark.parametrize("key_type", [KeyType.TEST, KeyType.NORMAL])
@pytest.mark.skip("We currently don't support international numbers")
# @pytest.mark.skip("We currently don't support international numbers")
def test_validate_and_format_recipient_succeeds_with_international_numbers_if_service_does_allow_int_sms(
key_type, sample_service_full_permissions
):

View File

@@ -1153,7 +1153,6 @@ def test_should_allow_store_original_number_on_sms_notification(
assert "1" == notifications[0].to
# @pytest.mark.skip("We don't support international at moment")
def test_should_not_allow_sending_to_international_number_without_international_permission(
client, sample_template, mocker
):
@@ -1178,7 +1177,6 @@ def test_should_not_allow_sending_to_international_number_without_international_
assert error_json["message"] == "Cannot send to international mobile numbers"
# @pytest.mark.skip("We don't support international at the moment")
def test_should_allow_sending_to_international_number_with_international_permission(
client, sample_service_full_permissions, mocker
):

View File

@@ -342,7 +342,6 @@ def test_post_user_attribute_with_updated_by(
mock_persist_notification.assert_not_called()
@pytest.mark.skip("We don't support international at the moment")
def test_post_user_attribute_with_updated_by_sends_notification_to_international_from_number(
admin_request, mocker, sample_user, team_member_mobile_edit_template
):

View File

@@ -499,7 +499,6 @@ def test_send_user_email_code(
)
# @pytest.mark.skip(reason="Broken email functionality")
def test_send_user_email_code_with_urlencoded_next_param(
admin_request, mocker, sample_user, email_2fa_code_template
):