darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-07-28 11:49:42 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix or remove skipped tests

Browse Source
This commit is contained in:
Kenneth Kehl
2025-08-29 08:48:43 -07:00
parent 0490b44fcd
commit 6dd5e320c9
5 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/app/notifications/test_validators.py
View File

@@ -473,9 +473,7 @@ def test_validate_template_calls_all_validators_exception_message_too_long(
@pytest.mark.parametrize("key_type", [KeyType.TEST, KeyType.NORMAL])
@pytest.mark.skip(
"We currently don't support international numbers, our validation fails before here"
)
# @pytest.mark.skip("We currently don't support international numbers")
def test_validate_and_format_recipient_fails_when_international_number_and_service_does_not_allow_int_sms(
key_type,
notify_db_session,
@@ -495,7 +493,7 @@ def test_validate_and_format_recipient_fails_when_international_number_and_servi
@pytest.mark.parametrize("key_type", [KeyType.TEST, KeyType.NORMAL])
@pytest.mark.skip("We currently don't support international numbers")
# @pytest.mark.skip("We currently don't support international numbers")
def test_validate_and_format_recipient_succeeds_with_international_numbers_if_service_does_allow_int_sms(
key_type, sample_service_full_permissions
):

2
tests/app/service/send_notification/test_send_notification.py
View File

@@ -1153,7 +1153,6 @@ def test_should_allow_store_original_number_on_sms_notification(
assert "1" == notifications[0].to
# @pytest.mark.skip("We don't support international at moment")
def test_should_not_allow_sending_to_international_number_without_international_permission(
client, sample_template, mocker
):
@@ -1178,7 +1177,6 @@ def test_should_not_allow_sending_to_international_number_without_international_
assert error_json["message"] == "Cannot send to international mobile numbers"
# @pytest.mark.skip("We don't support international at the moment")
def test_should_allow_sending_to_international_number_with_international_permission(
client, sample_service_full_permissions, mocker
):

1
tests/app/user/test_rest.py
View File

@@ -342,7 +342,6 @@ def test_post_user_attribute_with_updated_by(
mock_persist_notification.assert_not_called()
@pytest.mark.skip("We don't support international at the moment")
def test_post_user_attribute_with_updated_by_sends_notification_to_international_from_number(
admin_request, mocker, sample_user, team_member_mobile_edit_template
):

1
tests/app/user/test_rest_verify.py
View File

@@ -499,7 +499,6 @@ def test_send_user_email_code(
)
# @pytest.mark.skip(reason="Broken email functionality")
def test_send_user_email_code_with_urlencoded_next_param(
admin_request, mocker, sample_user, email_2fa_code_template
):