darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Kenneth Kehl
2024-01-22 10:55:09 -08:00
parent ed3a356ad1
commit 6dc9828663
19 changed files with 282 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/app/notifications/test_rest.py
View File

@@ -15,8 +15,15 @@ from tests.app.db import create_api_key, create_notification
@pytest.mark.parametrize("type", ("email", "sms"))
def test_get_notification_by_id(
client, sample_notification, sample_email_notification, type
client, sample_notification, sample_email_notification, type, mocker
):
mock_s3 = mocker.patch("app.notifications.rest.get_phone_number_from_s3")
mock_s3.return_value = "2028675309"
mock_s3_personalisation = mocker.patch(
"app.notifications.rest.get_personalisation_from_s3"
)
mock_s3_personalisation.return_value = {}
if type == "email":
notification_to_get = sample_email_notification
if type == "sms":
@@ -269,7 +276,16 @@ def test_only_normal_api_keys_can_return_job_notifications(
sample_team_api_key,
sample_test_api_key,
key_type,
mocker,
):
mock_s3 = mocker.patch("app.notifications.rest.get_phone_number_from_s3")
mock_s3.return_value = "2028675309"
mock_s3_personalisation = mocker.patch(
"app.notifications.rest.get_personalisation_from_s3"
)
mock_s3_personalisation.return_value = {}
normal_notification = create_notification(
template=sample_template, api_key=sample_api_key, key_type=KEY_TYPE_NORMAL
)
@@ -526,8 +542,10 @@ def test_get_notification_by_id_returns_merged_template_content(
def test_get_notification_by_id_returns_merged_template_content_for_email(
client, sample_email_template_with_placeholders
client, sample_email_template_with_placeholders, mocker
):
mock_s3 = mocker.patch("app.notifications.rest.get_personalisation_from_s3")
mock_s3.return_value = {"name": "foo"}
sample_notification = create_notification(
sample_email_template_with_placeholders, personalisation={"name": "world"}
)
@@ -547,8 +565,10 @@ def test_get_notification_by_id_returns_merged_template_content_for_email(
def test_get_notifications_for_service_returns_merged_template_content(
client, sample_template_with_placeholders
client, sample_template_with_placeholders, mocker
):
mock_s3 = mocker.patch("app.notifications.rest.get_personalisation_from_s3")
mock_s3.return_value = {"name": "foo"}
with freeze_time("2001-01-01T12:00:00"):
create_notification(
sample_template_with_placeholders,
@@ -578,7 +598,7 @@ def test_get_notifications_for_service_returns_merged_template_content(
def test_get_notification_selects_correct_template_for_personalisation(
client, notify_db_session, sample_template
client, notify_db_session, sample_template, mocker
):
create_notification(sample_template)
original_content = sample_template.content
@@ -586,6 +606,9 @@ def test_get_notification_selects_correct_template_for_personalisation(
dao_update_template(sample_template)
notify_db_session.commit()
mock_s3 = mocker.patch("app.notifications.rest.get_personalisation_from_s3")
mock_s3.return_value = {"name": "foo"}
create_notification(sample_template, personalisation={"name": "foo"})
auth_header = create_service_authorization_header(