From 0379d721e58ceef745d753def4f254af4d51a125 Mon Sep 17 00:00:00 2001 From: Ben Thorner Date: Fri, 12 Mar 2021 12:32:22 +0000 Subject: [PATCH] Add missing statsd timers to celery tasks All other tasks in app/celery/*_tasks.py have timers on them. Some of these timers will be useful to check before/after performance as a way to reassure ourselves about the impact of [1]. [1]: https://github.com/alphagov/notifications-api/pull/3172 --- app/celery/letters_pdf_tasks.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/celery/letters_pdf_tasks.py b/app/celery/letters_pdf_tasks.py index ff4d236ed..42ced40d1 100644 --- a/app/celery/letters_pdf_tasks.py +++ b/app/celery/letters_pdf_tasks.py @@ -119,6 +119,7 @@ def update_billable_units_for_letter(self, notification_id, page_count): @notify_celery.task(name='collate-letter-pdfs-to-be-sent') @cronitor("collate-letter-pdfs-to-be-sent") +@statsd(namespace="tasks") def collate_letter_pdfs_to_be_sent(): """ Finds all letters which are still waiting to be sent to DVLA for printing @@ -284,6 +285,7 @@ def group_letters(letter_pdfs): @notify_celery.task(bind=True, name='sanitise-letter', max_retries=15, default_retry_delay=300) +@statsd(namespace="tasks") def sanitise_letter(self, filename): try: reference = get_reference_from_filename(filename) @@ -322,6 +324,7 @@ def sanitise_letter(self, filename): @notify_celery.task(bind=True, name='process-sanitised-letter', max_retries=15, default_retry_delay=300) +@statsd(namespace="tasks") def process_sanitised_letter(self, sanitise_data): letter_details = encryption.decrypt(sanitise_data) @@ -436,6 +439,7 @@ def _move_invalid_letter_and_update_status( @notify_celery.task(name='process-virus-scan-failed') +@statsd(namespace="tasks") def process_virus_scan_failed(filename): move_failed_pdf(filename, ScanErrorType.FAILURE) reference = get_reference_from_filename(filename) @@ -455,6 +459,7 @@ def process_virus_scan_failed(filename): @notify_celery.task(name='process-virus-scan-error') +@statsd(namespace="tasks") def process_virus_scan_error(filename): move_failed_pdf(filename, ScanErrorType.ERROR) reference = get_reference_from_filename(filename)