darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 09:26:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

New endpoints to add and update multiple SMS sender for a service.

Browse Source
This commit is contained in:
Rebecca Law
2017-10-19 09:58:23 +01:00
parent 4ac2dc3606
commit 6dc41c3b47
5 changed files with 243 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
app/service/rest.py
View File

@@ -17,12 +17,14 @@ from app.dao.api_key_dao import (
get_model_api_keys,
get_unsigned_secret,
expire_api_key)
from app.dao.inbound_numbers_dao import dao_allocate_number_for_service
from app.dao.service_inbound_api_dao import (
save_service_inbound_api,
reset_service_inbound_api,
get_service_inbound_api
)
from app.dao.service_sms_sender_dao import insert_or_update_service_sms_sender
from app.dao.service_sms_sender_dao import insert_or_update_service_sms_sender, dao_add_sms_sender_for_service, \
dao_update_service_sms_sender, dao_get_service_sms_senders_by_id
from app.dao.services_dao import (
dao_fetch_service_by_id,
dao_fetch_all_services,
@@ -73,7 +75,7 @@ from app.service.service_inbound_api_schema import service_inbound_api, update_s
from app.service.service_senders_schema import (
add_service_email_reply_to_request,
add_service_letter_contact_block_request,
)
add_service_sms_sender_request)
from app.service.utils import get_whitelist_objects
from app.service.sender import send_notification_to_service_users
from app.service.send_notification import send_one_off_notification
@@ -619,6 +621,40 @@ def update_service_letter_contact(service_id, letter_contact_id):
return jsonify(data=new_reply_to.serialize()), 200
@service_blueprint.route('/<uuid:service_id>/sms-sender', methods=['POST'])
def add_service_sms_sender(service_id):
dao_fetch_service_by_id(service_id)
form = validate(request.get_json(), add_service_sms_sender_request)
inbound_number_id = form.get('inbound_number_id', None)
if inbound_number_id:
dao_allocate_number_for_service(service_id=service_id, inbound_number_id=inbound_number_id)
new_sms_sender = dao_add_sms_sender_for_service(service_id=service_id,
sms_sender=form['sms_sender'],
is_default=form['is_default'],
inbound_number_id=inbound_number_id
)
return jsonify(data=new_sms_sender.serialize()), 201
@service_blueprint.route('/<uuid:service_id>/sms-sender/<uuid:sms_sender_id>', methods=['POST'])
def update_service_sms_sender(service_id, sms_sender_id):
dao_fetch_service_by_id(service_id)
form = validate(request.get_json(), add_service_sms_sender_request)
sms_sender_to_update = dao_get_service_sms_senders_by_id(service_id=service_id,
service_sms_sender_id=sms_sender_id)
if sms_sender_to_update.inbound_number_id and form['sms_sender'] != sms_sender_to_update.sms_sender:
raise InvalidRequest("You can not change the inbound number for service {}".format(service_id),
status_code=400)
new_sms_sender = dao_update_service_sms_sender(service_id=service_id,
service_sms_sender_id=sms_sender_id,
is_default=form['is_default'],
sms_sender=form['sms_sender']
)
return jsonify(data=new_sms_sender.serialize()), 200
@service_blueprint.route('/unique', methods=["GET"])
def is_service_name_unique():
name, email_from = check_request_args(request)