darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 13:38:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix broken go live email notification

Browse Source
This commit is contained in:
Kenneth Kehl
2024-11-27 10:19:09 -08:00
parent 9b392af576
commit 6c0cbd2d34
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/service/sender.py
View File

@@ -25,6 +25,7 @@ def send_notification_to_service_users(
template = dao_get_template_by_id(template_id) template = dao_get_template_by_id(template_id)
service = dao_fetch_service_by_id(service_id) service = dao_fetch_service_by_id(service_id)
active_users = dao_fetch_active_users_for_service(service.id) active_users = dao_fetch_active_users_for_service(service.id)
print(hilite(f"ACTIVE USERS ARE {active_users}"))
notify_service = dao_fetch_service_by_id(current_app.config["NOTIFY_SERVICE_ID"]) notify_service = dao_fetch_service_by_id(current_app.config["NOTIFY_SERVICE_ID"])
for user in active_users: for user in active_users:

10
tests/app/service/test_sender.py
View File

@@ -1,9 +1,10 @@
import pytest import pytest
from flask import current_app from flask import current_app
from app.utils import hilite
from sqlalchemy import func, select from sqlalchemy import func, select
from app import db from app import db
from app.dao.services_dao import dao_add_user_to_service from app.dao.services_dao import dao_add_user_to_service, dao_fetch_active_users_for_service
from app.enums import NotificationType, TemplateType from app.enums import NotificationType, TemplateType
from app.models import Notification from app.models import Notification
from app.service.sender import send_notification_to_service_users from app.service.sender import send_notification_to_service_users
@@ -91,8 +92,15 @@ def test_send_notification_to_service_users_sends_to_active_users_only(
second_active_user = create_user(email="foo1@bar.com", state="active") second_active_user = create_user(email="foo1@bar.com", state="active")
pending_user = create_user(email="foo2@bar.com", state="pending") pending_user = create_user(email="foo2@bar.com", state="pending")
service = create_service(user=first_active_user) service = create_service(user=first_active_user)
print(hilite(f"CREATED THE SERVICE {service} with user {first_active_user}"))
dao_add_user_to_service(service, second_active_user) dao_add_user_to_service(service, second_active_user)
print(hilite(f"ADDED user {second_active_user}"))
dao_add_user_to_service(service, pending_user) dao_add_user_to_service(service, pending_user)
print(hilite(f"ADDED PENDING USER {pending_user}"))
active_users = dao_fetch_active_users_for_service(service.id)
print(hilite(f"ACTIVE USERS IN THE TEST {active_users}"))
template = create_template(service, template_type=TemplateType.EMAIL) template = create_template(service, template_type=TemplateType.EMAIL)
send_notification_to_service_users(service_id=service.id, template_id=template.id) send_notification_to_service_users(service_id=service.id, template_id=template.id)