New endpoint to insert new service reply to email address and update existing one.

This commit is contained in:
Rebecca Law
2017-09-14 17:54:38 +01:00
parent a5d3b787e1
commit 6b2c2962c9
6 changed files with 274 additions and 6 deletions

View File

@@ -2,8 +2,8 @@ import pytest
from app.dao.service_email_reply_to_dao import (
create_or_update_email_reply_to,
dao_get_reply_to_by_service_id
)
dao_get_reply_to_by_service_id,
add_reply_to_email_address_for_service, update_reply_to_email_address)
from app.errors import InvalidRequest
from app.models import ServiceEmailReplyTo
from tests.app.db import create_reply_to_email, create_service
@@ -65,3 +65,116 @@ def test_dao_get_reply_to_by_service_id(notify_db_session):
assert len(results) == 2
assert default_reply_to in results
assert another_reply_to in results
def test_add_reply_to_email_address_for_service_creates_first_email_for_service(notify_db_session):
service = create_service()
add_reply_to_email_address_for_service(service_id=service.id, email_address='new@address.com')
results = dao_get_reply_to_by_service_id(service_id=service.id)
assert len(results) == 1
assert results[0].email_address == 'new@address.com'
assert results[0].is_default
def test_add_reply_to_email_address_for_service_creates_another_email_for_service(notify_db_session):
service = create_service()
first_reply_to = create_reply_to_email(service=service, email_address="first@address.com")
add_reply_to_email_address_for_service(service_id=service.id, email_address='second@address.com', is_default=False)
results = dao_get_reply_to_by_service_id(service_id=service.id)
assert len(results) == 2
for x in results:
if x.email_address == 'first@address.com':
assert x.is_default
elif x.email_address == 'second@address.com':
assert not x.is_default
else:
assert False
def test_add_reply_to_email_address_new_reply_to_is_default_existing_reply_to_is_not(notify_db_session):
service = create_service()
first_reply_to = create_reply_to_email(service=service, email_address="first@address.com", is_default=True)
add_reply_to_email_address_for_service(service_id=service.id, email_address='second@address.com', is_default=True)
results = dao_get_reply_to_by_service_id(service_id=service.id)
assert len(results) == 2
for x in results:
if x.email_address == 'first@address.com':
assert not x.is_default
elif x.email_address == 'second@address.com':
assert x.is_default
else:
assert False
def test_add_reply_to_email_address_can_add_a_third_reply_to_address(sample_service):
add_reply_to_email_address_for_service(service_id=sample_service.id,
email_address="first@address.com")
add_reply_to_email_address_for_service(service_id=sample_service.id, email_address='second@address.com',
is_default=False)
add_reply_to_email_address_for_service(service_id=sample_service.id, email_address='third@address.com',
is_default=False)
results = dao_get_reply_to_by_service_id(service_id=sample_service.id)
assert len(results) == 3
for x in results:
if x.email_address == 'first@address.com':
assert x.is_default
elif x.email_address == 'second@address.com':
assert not x.is_default
elif x.email_address == 'third@address.com':
assert not x.is_default
else:
assert False
def test_add_reply_to_email_address_ensures_first_reply_to_is_default(sample_service):
with pytest.raises(expected_exception=InvalidRequest):
add_reply_to_email_address_for_service(service_id=sample_service.id,
email_address="first@address.com", is_default=False)
def test_update_reply_to_email_address(sample_service):
first_reply_to = create_reply_to_email(service=sample_service, email_address="first@address.com")
update_reply_to_email_address(service_id=sample_service.id, reply_to_id=first_reply_to.id,
email_address='change_address@email.com')
updated_reply_to = ServiceEmailReplyTo.query.get(first_reply_to.id)
assert updated_reply_to.email_address == 'change_address@email.com'
assert updated_reply_to.updated_at
assert updated_reply_to.is_default
def test_update_reply_to_email_address_set_updated_to_default(sample_service):
first_reply_to = create_reply_to_email(service=sample_service, email_address="first@address.com")
second_reply_to = create_reply_to_email(service=sample_service,
email_address="second@address.com",
is_default=False)
update_reply_to_email_address(service_id=sample_service.id,
reply_to_id=second_reply_to.id,
email_address='change_address@email.com',
is_default=True)
results = ServiceEmailReplyTo.query.all()
assert len(results) == 2
for x in results:
if x.email_address == 'change_address@email.com':
assert x.is_default
elif x.email_address == 'first@address.com':
assert not x.is_default
else:
assert False
def test_update_reply_to_email_address_raises_exception_if_single_reply_to_and_setting_default_to_false(sample_service):
first_reply_to = create_reply_to_email(service=sample_service, email_address="first@address.com")
with pytest.raises(expected_exception=InvalidRequest):
update_reply_to_email_address(service_id=sample_service.id,
reply_to_id=first_reply_to.id,
email_address='should@fail.com',
is_default=False)