darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don’t return jobs sent from contact lists

Browse Source 
Now that we’re grouping jobs sent from contact lists within their
parent, they shouldn’t also be listed on the jobs page at the top level.

The jobs page uses the uploads API, not the jobs API, so this commit
makes sure that filtering is happening in the proper place.
This commit is contained in:
Chris Hill-Scott
2020-12-01 15:23:38 +00:00
parent 10e1fe6902
commit 682cbc5130
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/app/dao/test_uploads_dao.py
View File

@@ -3,7 +3,14 @@ from freezegun import freeze_time
from app.dao.uploads_dao import dao_get_uploads_by_service_id, dao_get_uploaded_letters_by_print_date
from app.models import LETTER_TYPE, JOB_STATUS_IN_PROGRESS
from tests.app.db import create_job, create_service, create_service_data_retention, create_template, create_notification
from tests.app.db import (
create_job,
create_service,
create_service_data_retention,
create_service_contact_list,
create_template,
create_notification,
)
def create_uploaded_letter(letter_template, service, status='created', created_at=None):
@@ -34,6 +41,9 @@ def create_uploaded_template(service):
@freeze_time("2020-02-02 14:00") # GMT time
def test_get_uploads_for_service(sample_template):
create_service_data_retention(sample_template.service, 'sms', days_of_retention=9)
contact_list = create_service_contact_list()
# Jobs created from contact lists should be filtered out
create_job(sample_template, contact_list_id=contact_list.id)
job = create_job(sample_template, processing_started=datetime.utcnow())
letter_template = create_uploaded_template(sample_template.service)
letter = create_uploaded_letter(letter_template, sample_template.service)