darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #993 from GSA/notify-api-843

Browse Source 
bring coverage back up to 95%
This commit is contained in:
Carlo Costino
2024-05-31 11:36:47 -04:00
committed by GitHub
parent a3ef6de5bc f74d08a66a
commit 67392e64e3
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/checks.yml vendored
View File

@@ -53,7 +53,7 @@ jobs:
- name: Check for dead code - name: Check for dead code
run: make dead-code run: make dead-code
- name: Run tests with coverage - name: Run tests with coverage
run: poetry run coverage run --omit=*/notifications_utils/* -m pytest --maxfail=10 run: poetry run coverage run --omit=*/notifications_utils/*,*/migrations/* -m pytest --maxfail=10
env: env:
SQLALCHEMY_DATABASE_TEST_URI: postgresql://user:password@localhost:5432/test_notification_api SQLALCHEMY_DATABASE_TEST_URI: postgresql://user:password@localhost:5432/test_notification_api
NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }} NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }}
@@ -62,7 +62,7 @@ jobs:
NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }} NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }}
- name: Check coverage threshold - name: Check coverage threshold
# TODO get this back up to 95 # TODO get this back up to 95
run: poetry run coverage report --fail-under=87 run: poetry run coverage report --fail-under=95
validate-new-relic-config: validate-new-relic-config:
runs-on: ubuntu-latest runs-on: ubuntu-latest

3
Makefile
View File

@@ -81,7 +81,8 @@ test: ## Run tests and create coverage report
poetry run black . poetry run black .
poetry run flake8 . poetry run flake8 .
poetry run isort --check-only ./app ./tests poetry run isort --check-only ./app ./tests
poetry run coverage run -m pytest --maxfail=10 poetry run coverage run --omit=*/notifications_utils/*,*/migrations/* -m pytest --maxfail=10
poetry run coverage report -m --fail-under=95 poetry run coverage report -m --fail-under=95
poetry run coverage html -d .coverage_cache poetry run coverage html -d .coverage_cache