darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 23:41:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1054 from GSA/api-1044_Test_Bug

Browse Source 
API-1044 - Fixing the test to be less fragile.
This commit is contained in:
Carlo Costino
2024-06-04 16:16:22 -04:00
committed by GitHub
parent 495e15da84 77f4d85e74
commit 66751a8889
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/app/dao/test_service_sms_sender_dao.py
View File

@@ -159,16 +159,11 @@ def test_dao_update_service_sms_sender_switches_default(notify_db_session):
is_default=True, is_default=True,
sms_sender="updated", sms_sender="updated",
) )
sms_senders = ( sms_senders = ServiceSmsSender.query.filter_by(service_id=service.id).all()
ServiceSmsSender.query.filter_by(service_id=service.id)
.order_by(ServiceSmsSender.created_at) expected = {("testing", False), ("updated", True)}
.all() results = {(sender.sms_sender, sender.is_default) for sender in sms_senders}
) assert expected == results
assert len(sms_senders) == 2
assert sms_senders[0].sms_sender == "testing"
assert not sms_senders[0].is_default
assert sms_senders[1].sms_sender == "updated"
assert sms_senders[1].is_default
def test_dao_update_service_sms_sender_raises_exception_when_no_default_after_update( def test_dao_update_service_sms_sender_raises_exception_when_no_default_after_update(