darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding a cancel-letter-job endpoint to cancel a letter job.

Browse Source
This commit is contained in:
Rebecca Law
2019-06-12 14:50:08 +01:00
committed by Pea Tyczynska
parent 6565c19a9b
commit 663b260777
3 changed files with 41 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/job/rest.py
View File

@@ -5,7 +5,6 @@ from flask import (
request,
current_app
)
from notifications_utils.letter_timings import letter_can_be_cancelled
from app.aws.s3 import get_job_metadata_from_s3
from app.dao.jobs_dao import (
@@ -14,7 +13,9 @@ from app.dao.jobs_dao import (
dao_get_job_by_service_id_and_job_id,
dao_get_jobs_by_service_id,
dao_get_future_scheduled_job_by_id_and_service_id,
dao_get_notification_outcomes_for_job, dao_cancel_letter_job
dao_get_notification_outcomes_for_job,
dao_cancel_letter_job,
can_cancel_letter_job
)
from app.dao.fact_notification_status_dao import fetch_notification_statuses_for_job
from app.dao.services_dao import dao_fetch_service_by_id
@@ -62,6 +63,19 @@ def cancel_job(service_id, job_id):
return get_job_by_service_and_job_id(service_id, job_id)
@job_blueprint.route('/<job_id>/cancel-letter-job')
def cancel_letter_job(service_id, job_id):
job = dao_get_job_by_service_id_and_job_id(service_id, job_id)
if can_cancel_letter_job(job):
dao_cancel_letter_job(job)
return jsonify(), 201
else:
# reasons the letter can't be cancelled:
# letters are not yet saved to db --> can still cancel but later
# it's too late
return jsonify("CHANGE ME: some error to say the job can't be cancelled"), 400
@job_blueprint.route('/<job_id>/notifications', methods=['GET'])
def get_all_notifications_for_service_job(service_id, job_id):
data = notifications_filter_schema.load(request.args).data