darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 23:41:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Move happy path request-based tests to top of file

Browse Source 
We can simplify the rest of the tests to avoid the boilerplate of
making an actual request. But it's worth keeping these two to prove
the wrapper work correctly for an arbitrary route.
This commit is contained in:
Ben Thorner
2021-07-29 11:00:10 +01:00
parent 9da937ab1d
commit 65d0dc43f0
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/app/authentication/test_authentication.py
View File

@@ -50,6 +50,22 @@ def admin_jwt_token():
return create_jwt_token(admin_jwt_secret, admin_jwt_client_id) return create_jwt_token(admin_jwt_secret, admin_jwt_client_id)
def test_requires_auth_should_allow_valid_token_for_request_with_path_params_for_public_url(
client,
service_jwt_token,
):
response = client.get('/notifications', headers={'Authorization': 'Bearer {}'.format(service_jwt_token)})
assert response.status_code == 200
def test_requires_admin_auth_should_allow_valid_token_for_request_with_path_params(
client,
admin_jwt_token
):
response = client.get('/service', headers={'Authorization': 'Bearer {}'.format(admin_jwt_token)})
assert response.status_code == 200
def test_get_auth_token_should_not_allow_request_with_no_token(client): def test_get_auth_token_should_not_allow_request_with_no_token(client):
request.headers = {} request.headers = {}
with pytest.raises(AuthError) as exc: with pytest.raises(AuthError) as exc:
@@ -233,22 +249,6 @@ def test_requires_auth_should_not_allow_service_id_with_the_wrong_data_type(
assert data['message'] == {"token": ['Invalid token: service id is not the right data type']} assert data['message'] == {"token": ['Invalid token: service id is not the right data type']}
def test_requires_auth_should_allow_valid_token_for_request_with_path_params_for_public_url(
client,
service_jwt_token,
):
response = client.get('/notifications', headers={'Authorization': 'Bearer {}'.format(service_jwt_token)})
assert response.status_code == 200
def test_requires_admin_auth_should_allow_valid_token_for_request_with_path_params(
client,
admin_jwt_token
):
response = client.get('/service', headers={'Authorization': 'Bearer {}'.format(admin_jwt_token)})
assert response.status_code == 200
def test_requires_auth_returns_error_when_service_doesnt_exist( def test_requires_auth_returns_error_when_service_doesnt_exist(
client, client,
sample_api_key sample_api_key