From 65c21f694c98ea838abab6dd6d01c4cb07aa8ca3 Mon Sep 17 00:00:00 2001 From: sakisv Date: Thu, 9 Sep 2021 16:44:19 +0300 Subject: [PATCH] Don't raise P1 for broadcasts This is happening on the AWS side now as part of alphagov/notifications-broadcasts-infra#267 - but we still want to keep the zendesk ticket as it contains useful context _and_ provides visibility to the team. --- app/celery/broadcast_message_tasks.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/celery/broadcast_message_tasks.py b/app/celery/broadcast_message_tasks.py index 641e63f21..ddffd8a2a 100644 --- a/app/celery/broadcast_message_tasks.py +++ b/app/celery/broadcast_message_tasks.py @@ -58,7 +58,7 @@ def check_event_is_authorised_to_be_sent(broadcast_event, provider): def check_event_makes_sense_in_sequence(broadcast_event, provider): """ If any previous event hasn't sent yet for that provider, then we shouldn't send the current event. Instead, fail and - raise a P1 - so that a notify team member can assess the state of the previous messages, and if necessary, can + raise a zendesk ticket - so that a notify team member can assess the state of the previous messages, and if necessary, can replay the `send_broadcast_provider_message` task if the previous message has now been sent. Note: This is called before the new broadcast_provider_message is created. @@ -128,7 +128,7 @@ def send_broadcast_event(broadcast_event_id): broadcast_event.message_type == BroadcastEventMessageType.ALERT ): broadcast_message = broadcast_event.broadcast_message - # raise a P1 to alert team that broadcast is going out. + # raise a zendesk ticket to alert team that broadcast is going out. message = '\n'.join([ 'Broadcast Sent', '', @@ -146,7 +146,6 @@ def send_broadcast_event(broadcast_event_id): subject="Live broadcast sent", message=message, ticket_type=zendesk_client.TYPE_INCIDENT, - p1=True, ) current_app.logger.error(message)