darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 09:26:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback and merge from main

Browse Source
This commit is contained in:
Kenneth Kehl
2024-09-11 09:39:18 -07:00
parent b9e400de42 1b98f45a7e
commit 64a85868a3
34 changed files with 256 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notifications/receive_notifications.py
View File

@@ -117,7 +117,7 @@ def fetch_potential_service(inbound_number, provider_name):
if not has_inbound_sms_permissions(service.permissions):
current_app.logger.error(
'Service "{}" does not allow inbound SMS'.format(service.id), exc_info=True
'Service "{}" does not allow inbound SMS'.format(service.id)
)
return False

7
app/notifications/sns_handlers.py
View File

@@ -31,7 +31,7 @@ def sns_notification_handler(data, headers):
verify_message_type(message_type)
except InvalidMessageTypeException:
current_app.logger.exception(
f"Response headers: {headers}\nResponse data: {data}", exc_info=True
f"Response headers: {headers}\nResponse data: {data}"
)
raise InvalidRequest("SES-SNS callback failed: invalid message type", 400)
@@ -39,7 +39,7 @@ def sns_notification_handler(data, headers):
message = json.loads(data.decode("utf-8"))
except decoder.JSONDecodeError:
current_app.logger.exception(
f"Response headers: {headers}\nResponse data: {data}", exc_info=True
f"Response headers: {headers}\nResponse data: {data}"
)
raise InvalidRequest("SES-SNS callback failed: invalid JSON given", 400)
@@ -47,8 +47,7 @@ def sns_notification_handler(data, headers):
validate_sns_cert(message)
except Exception:
current_app.logger.error(
"SES-SNS callback failed: validation failed with error: Signature validation failed",
exc_info=True,
"SES-SNS callback failed: validation failed with error: Signature validation failed"
)
raise InvalidRequest("SES-SNS callback failed: validation failed", 400)