darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback and merge from main

Browse Source
This commit is contained in:
Kenneth Kehl
2024-09-11 09:39:18 -07:00
parent b9e400de42 1b98f45a7e
commit 64a85868a3
34 changed files with 256 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/clients/performance_platform/performance_platform_client.py
View File

@@ -41,8 +41,7 @@ class PerformancePlatformClient:
current_app.logger.error(
"Performance platform update request failed for payload with response details: {} '{}'".format(
json.dumps(payload), resp.status_code
),
exc_info=True,
)
)
resp.raise_for_status()

8
app/clients/sms/aws_sns.py
View File

@@ -80,14 +80,10 @@ class AwsSnsClient(SmsClient):
PhoneNumber=to, Message=content, MessageAttributes=attributes
)
except botocore.exceptions.ClientError as e:
self.current_app.logger.error(
"An error occurred sending sms", exc_info=True
)
self.current_app.logger.exception("An error occurred sending sms")
raise str(e)
except Exception as e:
self.current_app.logger.error(
"An error occurred sending sms", exc_info=True
)
self.current_app.logger.exception("An error occurred sending sms")
raise str(e)
finally:
elapsed_time = monotonic() - start_time