darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add a check that the folder is not moved into itself.

Browse Source 
By the way, the database will not let this happen, but this is a nicer error and is explicit to read as an invalid move.
This commit is contained in:
Rebecca Law
2018-11-09 16:08:33 +00:00
parent 1f86796949
commit 63b305441c
2 changed files with 32 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/app/template_folder/test_template_folder_rest.py
View File

@@ -330,6 +330,22 @@ def test_move_to_folder_rejects_if_it_would_cause_folder_loop(admin_request, sam
)
def test_move_to_folder_itself_is_rejected(admin_request, sample_service):
target_folder = create_template_folder(sample_service, name='target')
response = admin_request.post(
'template_folder.move_to_template_folder',
service_id=sample_service.id,
target_template_folder_id=target_folder.id,
_data={
'templates': [],
'folders': [str(target_folder.id)]
},
_expected_status=400
)
response['message'] == 'Could not move to folder: {} to itself'.format(target_folder.id)
def test_move_to_folder_skips_archived_templates(admin_request, sample_service):
target_folder = create_template_folder(sample_service)
other_folder = create_template_folder(sample_service)