From 6386cb968a24044403438b3a4fcc6d5759efdf2a Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Thu, 2 Mar 2017 12:12:01 +0000 Subject: [PATCH] Fix tests. Fix copy/paste error in the history table --- migrations/versions/0066_add_dvla_provider.py | 4 ++-- tests/app/dao/test_provider_details_dao.py | 2 +- tests/app/provider_details/test_rest.py | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/migrations/versions/0066_add_dvla_provider.py b/migrations/versions/0066_add_dvla_provider.py index 5f8a0c6ee..6da8c555c 100644 --- a/migrations/versions/0066_add_dvla_provider.py +++ b/migrations/versions/0066_add_dvla_provider.py @@ -17,10 +17,10 @@ from alembic import op def upgrade(): provider_id = str(uuid.uuid4()) op.execute( - "INSERT INTO provider_details (id, display_name, identifier, priority, notification_type, active, version) values ('{}', 'DVLA', 'dvla', 10, 'letter', true, 1)".format(provider_id) + "INSERT INTO provider_details (id, display_name, identifier, priority, notification_type, active, version) values ('{}', 'DVLA', 'dvla', 50, 'letter', true, 1)".format(provider_id) ) op.execute( - "INSERT INTO provider_details_history (id, display_name, identifier, priority, notification_type, active, version) values ('{}', 'DVLA', 'mmg', 10, 'sms', true, 1)".format(provider_id) + "INSERT INTO provider_details_history (id, display_name, identifier, priority, notification_type, active, version) values ('{}', 'DVLA', 'dvla', 50, 'letter', true, 1)".format(provider_id) ) op.execute("INSERT INTO provider_rates (id, valid_from, rate, provider_id) VALUES ('{}', '{}', 1.0, '{}')".format(uuid.uuid4(), datetime.utcnow(), provider_id)) diff --git a/tests/app/dao/test_provider_details_dao.py b/tests/app/dao/test_provider_details_dao.py index c4f77ed29..02344832b 100644 --- a/tests/app/dao/test_provider_details_dao.py +++ b/tests/app/dao/test_provider_details_dao.py @@ -31,7 +31,7 @@ def set_primary_sms_provider(identifier): def test_can_get_all_providers(restore_provider_details): - assert len(get_provider_details()) == 4 + assert len(get_provider_details()) == 5 def test_can_get_sms_providers(restore_provider_details): diff --git a/tests/app/provider_details/test_rest.py b/tests/app/provider_details/test_rest.py index b0a739296..63ffd0012 100644 --- a/tests/app/provider_details/test_rest.py +++ b/tests/app/provider_details/test_rest.py @@ -13,12 +13,13 @@ def test_get_provider_details_in_type_and_identifier_order(client, notify_db): ) assert response.status_code == 200 json_resp = json.loads(response.get_data(as_text=True))['provider_details'] - assert len(json_resp) == 4 + assert len(json_resp) == 5 assert json_resp[0]['identifier'] == 'ses' assert json_resp[1]['identifier'] == 'mmg' assert json_resp[2]['identifier'] == 'firetext' assert json_resp[3]['identifier'] == 'loadtesting' + assert json_resp[4]['identifier'] == 'dvla' def test_get_provider_details_by_id(client, notify_db):