darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix logic

Browse Source
This commit is contained in:
Kenneth Kehl
2024-12-02 12:15:32 -08:00
parent 791d18b4ec
commit 6124fbc6a4
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/celery/tasks.py
View File

@@ -346,9 +346,14 @@ def save_api_email_or_sms(self, encrypted_notification):
status=notification["status"], status=notification["status"],
document_download_count=notification["document_download_count"], document_download_count=notification["document_download_count"],
) )
# Only get here if save to the db was successful (i.e. first time)
provider_task.apply_async([notification["id"]], queue=q)
current_app.logger.debug(
f"{notification['notification_type']} {notification['id']} has been persisted and sent to delivery queue."
)
except IntegrityError: except IntegrityError:
current_app.logger.info( current_app.logger.warning(
f"{notification['notification_type']} {notification['id']} already exists." f"{notification['notification_type']} {notification['id']} already exists."
) )
# If we don't have the return statement here, we will fall through and end # If we don't have the return statement here, we will fall through and end
@@ -362,10 +367,6 @@ def save_api_email_or_sms(self, encrypted_notification):
current_app.logger.exception( current_app.logger.exception(
f"Max retry failed Failed to persist notification {notification['id']}", f"Max retry failed Failed to persist notification {notification['id']}",
) )
provider_task.apply_async([notification["id"]], queue=q)
current_app.logger.debug(
f"{notification['notification_type']} {notification['id']} has been persisted and sent to delivery queue."
)
def handle_exception(task, notification, notification_id, exc): def handle_exception(task, notification, notification_id, exc):