darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-17 18:52:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add notification_type to notification table.

Browse Source 
It seems like an oversight not to include the notification type in the notifcation.
When updating statistics a query to the template table is required to get the type, this update will mean that query does not have to happen.
This commit is contained in:
Rebecca Law
2016-06-29 11:23:02 +01:00
parent 340abae82c
commit 60e159e3c0
6 changed files with 35 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/celery/tasks.py
View File

@@ -157,7 +157,8 @@ def send_sms(self, service_id, notification_id, encrypted_notification, created_
job_row_number=notification.get('row_number', None),
status='created',
created_at=datetime.strptime(created_at, DATETIME_FORMAT),
personalisation=notification.get('personalisation')
personalisation=notification.get('personalisation'),
notification_type='sms'
)
dao_create_notification(notification_db_object, TEMPLATE_TYPE_SMS)
@@ -202,7 +203,8 @@ def send_email(service_id, notification_id, encrypted_notification, created_at,
created_at=datetime.strptime(created_at, DATETIME_FORMAT),
sent_at=sent_at,
sent_by=provider.get_name(),
personalisation=notification.get('personalisation')
personalisation=notification.get('personalisation'),
notification_type='email'
)
dao_create_notification(notification_db_object, TEMPLATE_TYPE_EMAIL)