darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 15:15:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don’t store the underlying dict

Browse Source 
This will give us smaller objects to cache, and forces us to be explicit
about which properties we’re using.
This commit is contained in:
Chris Hill-Scott
2020-06-22 10:20:52 +01:00
parent ad2328fc05
commit 608812d314
3 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/notifications/test_process_notification.py
View File

@@ -31,7 +31,7 @@ def test_create_content_for_notification_passes(sample_email_template):
sample_email_template.id, sample_email_template.service_id
)
content = create_content_for_notification(template, None)
assert str(content) == template._dict['content'] + '\n'
assert str(content) == template.content + '\n'
def test_create_content_for_notification_with_placeholders_passes(sample_template_with_placeholders):
@@ -39,7 +39,7 @@ def test_create_content_for_notification_with_placeholders_passes(sample_templat
sample_template_with_placeholders.id, sample_template_with_placeholders.service_id
)
content = create_content_for_notification(template, {'name': 'Bobby'})
assert content.content == template._dict['content']
assert content.content == template.content
assert 'Bobby' in str(content)